[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#904049: cricket: Please consider using getent instead of sg in maintscript



Source: cricket
Version: 1.0.5-21
Severity: wishlist
User: andreas@fatal.se
Usertags: sg-maintscript-removal

Hello,

Your package cricket was one of the few matches for 'sg' usage in
maintainer scripts[1].  As a preparation for potentially solving #833256
in the future, I'd like to ask you to change your package to adhere to
what seems to be the established defacto standard in maintainer-script
code for adding users/groups these days, eg.

if ! getent passwd | grep ^joeuser: > /dev/null; then
    adduser ...
fi

... and similar for groups with 'getent group'.

More examples can be found at
https://codesearch.debian.net/search?q=path%3A.*postinst+adduser
or for a specific example see:
https://sources.debian.org/src/util-linux/2.32-0.1/debian/uuid-runtime.postinst/

Please note that adding (and removing) system users and groups are still
not described in Debian Policy (see #228692), but this will eliminate
the need for the 'sg' utility and be more in line with what other
packages are doing.
If your package are removing users or groups during purge, you might
want to consider that there seems to be consensus against ever doing so
(see mailing list thread linked from #228692).

If time permits and I haven't heard anything back I'll consider fixing
this via a NMU while at DebCamp/DebConf.

Regards,
Andreas Henriksson

[1]: https://codesearch.debian.net/search?q=path%3Adebian%2F.*p%28ost%7Cre%29%28inst%7Crm%29+%5C+sg%5C+


Reply to: