[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#834324: marked as done (libnss-ldap: please make the build reproducible)

Your message dated Mon, 03 Oct 2016 12:07:38 +0000
with message-id <E1br21y-0002BT-0n@franck.debian.org>
and subject line Bug#834324: fixed in libnss-ldap 265-5
has caused the Debian Bug report #834324,
regarding libnss-ldap: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
834324: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=834324
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: libnss-ldap
Version: 265-3
Severity: wishlist
Tags: patch upstream
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps username
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that libnss-ldap could not be built reproducibly.
It embeds the build date and username into the version string.

The attached patch removes this to make the build reproducible.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds

diff --git a/debian/patches/reproducible-build.patch b/debian/patches/reproducible-build.patch
new file mode 100644
index 0000000..1a09400
--- /dev/null
+++ b/debian/patches/reproducible-build.patch
@@ -0,0 +1,43 @@
+Author: Reiner Herrmann <reiner@reiner-h.de>
+Description: Remove build user and date from version string to make build reproducible
+
+--- a/vers_string
++++ b/vers_string
+@@ -32,17 +32,17 @@
+ 	print $PROJECT, $SEP, $VERSION, "\n";
+ } elsif ($ARGV[0] eq "-l") {
+ 	print "static const char SGS_VERS[160] = \"";
+-	print '@(#)LIBRARY:', $PROGRAM, '  PROJECT:', $PROJECT, $SEP, $VERSION, '  DEVELOPER:', $AUTHOR,  '  BUILT:', $DATE;
++	print '@(#)LIBRARY:', $PROGRAM, '  PROJECT:', $PROJECT, $SEP, $VERSION;
+ 	print "\";\n";
+ } elsif ($ARGV[0] eq "-c") {
+ 	print "const char SGS_VERS[160] = \"";
+-	print '@(#)PROGRAM:', $PROGRAM, '  PROJECT:', $PROJECT, $SEP, $VERSION, '  DEVELOPER:', $AUTHOR,  '  BUILT:', $DATE;
++	print '@(#)PROGRAM:', $PROGRAM, '  PROJECT:', $PROJECT, $SEP, $VERSION;
+ 	print "\";\n";
+ 	print "const char VERS_NUM[10] = \"$VERSION\";\n";
+ } elsif ($ARGV[0] eq "-n") {
+ 	print "$VERSION\n";
+ } elsif ($ARGV[0] eq "-B") {
+-	print 'PROGRAM:', $PROGRAM, '  PROJECT:', $PROJECT, $SEP, $VERSION, '  DEVELOPER:', $AUTHOR,  '  BUILT:NO DATE SET (-B used)',"\n";
++	print 'PROGRAM:', $PROGRAM, '  PROJECT:', $PROJECT, $SEP, $VERSION,"\n";
+ } elsif ($ARGV[0] eq "-v") {
+ 	unlink($OUTFILE);
+ 	open(OUTFILE,">$OUTFILE");
+@@ -52,7 +52,7 @@
+ 		print OUTFILE "#define USE_SGS_VERS\n\n";
+ 	}
+ 	print OUTFILE "const char SGS_VERS[160] = \"";
+-	print OUTFILE '@(#)PROGRAM:', $PROGRAM, '  PROJECT:', $PROJECT, $SEP, $VERSION, '  DEVELOPER:', $AUTHOR,  '  BUILT:', $DATE;
++	print OUTFILE '@(#)PROGRAM:', $PROGRAM, '  PROJECT:', $PROJECT, $SEP, $VERSION;
+ 	print OUTFILE "\";\n\n";
+ 	print OUTFILE "const char VERS_NUM[10] = \"$VERSION\";\n\n";
+ 	close(OUTFILE);
+@@ -78,6 +78,6 @@
+ 	print STDERR "\tTo create a project distribution, type tarup\n";
+ 	print STDERR "\tTo commit a project, type commit [message]\n";
+ } else {
+-	print 'PROGRAM:', $PROGRAM, '  PROJECT:', $PROJECT, $SEP, $VERSION, '  DEVELOPER:', $AUTHOR,  '  BUILT:', $DATE;
++	print 'PROGRAM:', $PROGRAM, '  PROJECT:', $PROJECT, $SEP, $VERSION;
+ 	print "\n";
+ }
diff --git a/debian/patches/series b/debian/patches/series
index 15e2a8c..ec1b7ab 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -10,3 +10,4 @@ fix_ldap_sessions_mem_leak.patch
 spelling-fix.patch
 glibc-2.16.patch
 fix-nsswitch-example.patch
+reproducible-build.patch

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: libnss-ldap
Source-Version: 265-5

We believe that the bug you reported is fixed in the latest version of
libnss-ldap, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 834324@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated libnss-ldap package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 03 Oct 2016 13:00:50 +0100
Source: libnss-ldap
Binary: libnss-ldap
Architecture: source amd64
Version: 265-5
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 libnss-ldap - NSS module for using LDAP as a naming service
Closes: 834324
Changes:
 libnss-ldap (265-5) unstable; urgency=medium
 .
   * Actually apply Reiner Herrmann's patch that was missing in 265-4...
     (Closes: #834324)
Checksums-Sha1:
 4d94219afd6bddfbd5290db8f136bbc26f9daa4f 1956 libnss-ldap_265-5.dsc
 743581914fc8c9b4d33955c2cc7acd0c3c44a430 280976 libnss-ldap_265.orig.tar.gz
 6bf6a8cb490b8ea641dc24837daf406ebbb9fd41 54856 libnss-ldap_265-5.debian.tar.xz
 29e0baf153cbb7aa30677901c63169c334ed7922 115102 libnss-ldap-dbgsym_265-5_amd64.deb
 00634b60019ee3a8309deee491dd83a2c482ad7f 115046 libnss-ldap_265-5_amd64.deb
Checksums-Sha256:
 c11041c6bd264b410a9e7976dea7655a5a1de6918ae7466410802bb8f9387ef2 1956 libnss-ldap_265-5.dsc
 77b54d905f50d774f28d5559d49126f1bc76720f741b0864a64bb4936ec226a8 280976 libnss-ldap_265.orig.tar.gz
 16a26f559b93586becd26a59b3b3cae215bf94c1dc5cd7cc65c6a96bca6856c3 54856 libnss-ldap_265-5.debian.tar.xz
 22613969f9fd55b47d9c0f2af530189f1ea3879fe0e859c62bd44246bd28500c 115102 libnss-ldap-dbgsym_265-5_amd64.deb
 beb2cdf9f3f554fb4339c31cc5e7aca1c2be70d51cba43e36c269c7a2d3a62f8 115046 libnss-ldap_265-5_amd64.deb
Files:
 9146031d81d95c202e812ddd911a01f4 1956 admin extra libnss-ldap_265-5.dsc
 c1cb02d1a85538cf16bca6f6a562abe4 280976 admin extra libnss-ldap_265.orig.tar.gz
 2d26ebfe4e48e5b9e842af3cca17cb3c 54856 admin extra libnss-ldap_265-5.debian.tar.xz
 a34555cb029d4201e4eb1df0801b74de 115102 debug extra libnss-ldap-dbgsym_265-5_amd64.deb
 0c38f12d0ba1eb599a8df9bbc896e39d 115046 admin extra libnss-ldap_265-5_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJX8kkBAAoJEB6VPifUMR5Yfj0QAKO9mxRCojnK0le/4IliREj9
VbBm1BUZgFxF3m/Fi7M/t7ZEiRA5PScYjLSJJVejQAjtpZJ1Aut7/oFmF51HRRq8
3a+NdL+dKS5JL/tQY+BoljjhLe9NlpgfCgVFZzXSav1EwuhXSske8BgzKrh9vknu
PlwMzIAfjZkpC2G+mj2JI/uO9HyTCTNBNv3f0uUApym/RPot94MSibCr6gg9oJbf
Dl/Kn09ukzWSJrLjkhgMG99N5sWkHAtVp/K68OAXFXvv2Ek0ssw5ZAVtF8Sob9er
dYRkk6fPHG/TE9Gg1UngiX7yjEi7FHIJr4qhFelSCzGrw8TjBxk0GOE6IJxXTbdJ
0FEKdumHAIpOSrLmLjeoZl7vJ7cyzSUUVc00J7+L5QmEWrZ84nJFoKPHbTxCyLb8
PEn0JY/7RHzqE3oEkDE5E/E+Uavq3iLJxV1GFHwtuxQAXNZDRRQt60FOM+EW+RZ2
hsISA1dWeJ1Nnk50gtzCuDvQTrgEl1w25D4kkSx/+0kyklJdf4T8aL9zZMIpb/WT
0JPEqLVQYOtrGi8pKYxcc3EsTVJepVjLQrN7vG8+yhlNSU/MUGK371mSIbotH4jx
VZtfI8njW+yIWW1Lf6xwH28JBrY9eekEKaZcOAVd8evX73V+jbxUdevA2nsE8ozO
FIzlKPNx+3I24Wb0rkvx
=0Is1
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: