[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#834324: marked as done (libnss-ldap: please make the build reproducible)

Your message dated Sat, 01 Oct 2016 23:27:18 +0000
with message-id <E1bqTgc-0001Td-RL@franck.debian.org>
and subject line Bug#834324: fixed in libnss-ldap 265-4
has caused the Debian Bug report #834324,
regarding libnss-ldap: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
834324: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=834324
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: libnss-ldap
Version: 265-3
Severity: wishlist
Tags: patch upstream
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps username
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that libnss-ldap could not be built reproducibly.
It embeds the build date and username into the version string.

The attached patch removes this to make the build reproducible.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds

diff --git a/debian/patches/reproducible-build.patch b/debian/patches/reproducible-build.patch
new file mode 100644
index 0000000..1a09400
--- /dev/null
+++ b/debian/patches/reproducible-build.patch
@@ -0,0 +1,43 @@
+Author: Reiner Herrmann <reiner@reiner-h.de>
+Description: Remove build user and date from version string to make build reproducible
+
+--- a/vers_string
++++ b/vers_string
+@@ -32,17 +32,17 @@
+ 	print $PROJECT, $SEP, $VERSION, "\n";
+ } elsif ($ARGV[0] eq "-l") {
+ 	print "static const char SGS_VERS[160] = \"";
+-	print '@(#)LIBRARY:', $PROGRAM, '  PROJECT:', $PROJECT, $SEP, $VERSION, '  DEVELOPER:', $AUTHOR,  '  BUILT:', $DATE;
++	print '@(#)LIBRARY:', $PROGRAM, '  PROJECT:', $PROJECT, $SEP, $VERSION;
+ 	print "\";\n";
+ } elsif ($ARGV[0] eq "-c") {
+ 	print "const char SGS_VERS[160] = \"";
+-	print '@(#)PROGRAM:', $PROGRAM, '  PROJECT:', $PROJECT, $SEP, $VERSION, '  DEVELOPER:', $AUTHOR,  '  BUILT:', $DATE;
++	print '@(#)PROGRAM:', $PROGRAM, '  PROJECT:', $PROJECT, $SEP, $VERSION;
+ 	print "\";\n";
+ 	print "const char VERS_NUM[10] = \"$VERSION\";\n";
+ } elsif ($ARGV[0] eq "-n") {
+ 	print "$VERSION\n";
+ } elsif ($ARGV[0] eq "-B") {
+-	print 'PROGRAM:', $PROGRAM, '  PROJECT:', $PROJECT, $SEP, $VERSION, '  DEVELOPER:', $AUTHOR,  '  BUILT:NO DATE SET (-B used)',"\n";
++	print 'PROGRAM:', $PROGRAM, '  PROJECT:', $PROJECT, $SEP, $VERSION,"\n";
+ } elsif ($ARGV[0] eq "-v") {
+ 	unlink($OUTFILE);
+ 	open(OUTFILE,">$OUTFILE");
+@@ -52,7 +52,7 @@
+ 		print OUTFILE "#define USE_SGS_VERS\n\n";
+ 	}
+ 	print OUTFILE "const char SGS_VERS[160] = \"";
+-	print OUTFILE '@(#)PROGRAM:', $PROGRAM, '  PROJECT:', $PROJECT, $SEP, $VERSION, '  DEVELOPER:', $AUTHOR,  '  BUILT:', $DATE;
++	print OUTFILE '@(#)PROGRAM:', $PROGRAM, '  PROJECT:', $PROJECT, $SEP, $VERSION;
+ 	print OUTFILE "\";\n\n";
+ 	print OUTFILE "const char VERS_NUM[10] = \"$VERSION\";\n\n";
+ 	close(OUTFILE);
+@@ -78,6 +78,6 @@
+ 	print STDERR "\tTo create a project distribution, type tarup\n";
+ 	print STDERR "\tTo commit a project, type commit [message]\n";
+ } else {
+-	print 'PROGRAM:', $PROGRAM, '  PROJECT:', $PROJECT, $SEP, $VERSION, '  DEVELOPER:', $AUTHOR,  '  BUILT:', $DATE;
++	print 'PROGRAM:', $PROGRAM, '  PROJECT:', $PROJECT, $SEP, $VERSION;
+ 	print "\n";
+ }
diff --git a/debian/patches/series b/debian/patches/series
index 15e2a8c..ec1b7ab 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -10,3 +10,4 @@ fix_ldap_sessions_mem_leak.patch
 spelling-fix.patch
 glibc-2.16.patch
 fix-nsswitch-example.patch
+reproducible-build.patch

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: libnss-ldap
Source-Version: 265-4

We believe that the bug you reported is fixed in the latest version of
libnss-ldap, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 834324@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated libnss-ldap package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 01 Oct 2016 23:22:46 +0100
Source: libnss-ldap
Binary: libnss-ldap
Architecture: source amd64
Version: 265-4
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 libnss-ldap - NSS module for using LDAP as a naming service
Closes: 834324
Changes:
 libnss-ldap (265-4) unstable; urgency=medium
 .
   * QA upload.
   * Make the build reproducible. Thanks to Reiner Herrmann <reiner@reiner-h.de>
     for the patch. (Closes: #834324)
   * Bump Standards-Version to 3.9.8.
Checksums-Sha1:
 6085778fc7f7e50252b73bb3a36d3513aba0dfb0 1956 libnss-ldap_265-4.dsc
 743581914fc8c9b4d33955c2cc7acd0c3c44a430 280976 libnss-ldap_265.orig.tar.gz
 60f2fcdb71c419344f11671105e54dfa23e6fd6f 54360 libnss-ldap_265-4.debian.tar.xz
 502d4102ad7f312bcaaeb00de268d3192a605b37 115110 libnss-ldap-dbgsym_265-4_amd64.deb
 08bfbcb5b73028a41f798f588cc95185160ae164 115006 libnss-ldap_265-4_amd64.deb
Checksums-Sha256:
 52960d16a628ab378b5b0e94be39eab815179a96da2b0623e41ea8ef57e41617 1956 libnss-ldap_265-4.dsc
 77b54d905f50d774f28d5559d49126f1bc76720f741b0864a64bb4936ec226a8 280976 libnss-ldap_265.orig.tar.gz
 52b01e40ff30769c524d6d4023a62a6d3c5206626e47f80828802265a8e5359e 54360 libnss-ldap_265-4.debian.tar.xz
 0c7c6c78c3c0a973179e32fdc622289fff41d3b69b91519ffab7d523916d9d44 115110 libnss-ldap-dbgsym_265-4_amd64.deb
 844195793e8f9a6039de4f94a1056d0d4a87410a2518f0a4a5f03b04e6e8fbb3 115006 libnss-ldap_265-4_amd64.deb
Files:
 4b3167eb20e59940c322b5ed67711583 1956 admin extra libnss-ldap_265-4.dsc
 c1cb02d1a85538cf16bca6f6a562abe4 280976 admin extra libnss-ldap_265.orig.tar.gz
 4b3a35f1cfc2448ebf162eb50a7e7f81 54360 admin extra libnss-ldap_265-4.debian.tar.xz
 348a2cf97150888037b88e557d8606e7 115110 debug extra libnss-ldap-dbgsym_265-4_amd64.deb
 95ae9244a2695c63d48437547d615f04 115006 admin extra libnss-ldap_265-4_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJX8DdyAAoJEB6VPifUMR5Y6hYP/2qKjgYNme/YgZfVn8W83uyB
gOpao6DyUBb6zA+/MbmyZPUzuJCSmNQh8H1e7Xq7iNJeY0OPCQwa4A4DnJtemfc9
ZCNXaatXoeMAkGc3VykuusTLX9xkSwLQDw5f3KPLvNYee3h2XAbbGF0v/FuPoHgz
8kQzW+y0qxdXPvLKOo6o5eMHa12JoHms550DB1uvsyuChEvmcUp5Z56ga8++DoxW
3R4Ddiv3sQ5gmukZA1m07Snatkug/LM9RPpK8m1hwPVzBG9j8+dN86wVteuZj8Pq
xaWkUH3cxFvRNOODZ0N6XPl7eOsz6cG3okXrHjM/bmKzFvMAsWwOjc/jL3wvVCbp
iAqC5l32cUQZ/F6flAyB7fD0cX9AC6lav0pviUQVV3J/QpWtAV83x+pv3XCmWcJq
AGJajg6x3B8NCpEFGivbG8FH7K4LAOdvpiA7TzklyMfmnFPZyijW4ELSBAfpKQFQ
/cVqzWlrxesEGUitEU/0LIbECw9GskPmoiQDIoQMNizWXwcrgvmlSwkR/9NPqX3w
/40p4GJ2fiXJgF04JntWzZyANuYYmJExmE69AAF0UougsNqg1Ok75cMrskRGxMkG
KguuMhv/JlgXBP30t3ERXknCUIhjt+x0HlABrXmH0wuPwqThAD6TGkAQFDfnIuOn
AZYRmgUPBblVlXr/NJmH
=fhiZ
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: