--- Begin Message ---
- To: "Debian Bugtracker" <submit@bugs.debian.org>
- Subject: incorrect scaling with -fullscreen
- From: "Anton Khirnov" <wyskas@gmail.com>
- Date: Thu, 20 Nov 2008 20:34:00 +0100
- Message-id: <12b495d0811201134m190dd821md4568612eef6a4ab@mail.gmail.com>
Package: xloadimage
Version: 4.1-16
Severity: normal
Tags: patch
Hi,
-fullscreen option behaves incorrectly, if one of the images' dimensions
is bigger than screen, but the other is not. It's caused by a forgotten
typecast from uint to int. I'm attaching a patch that fixes it.
Anton Khirnov
-- System Information:
Debian Release: sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.27-nb.a (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages xloadimage depends on:
ii libc6 2.8+20080809-1 GNU C Library: Shared libraries
ii libjpeg62 6b-14 The Independent JPEG Group's JPEG
ii libpng12-0 1.2.27-2 PNG library - runtime
ii libtiff4 3.8.2-11 Tag Image File Format (TIFF) libra
ii libx11-6 2:1.1.5-2 X11 client-side library
ii zlib1g 1:1.2.3.3.dfsg-12 compression library - runtime
xloadimage recommends no packages.
xloadimage suggests no packages.
-- no debconf information
--- xloadimage.c 2008-11-20 20:17:46.000000000 +0100
+++ xloadimage.c 2008-11-20 20:23:28.000000000 +0100
@@ -370,8 +370,8 @@
if ((newimage->width > DisplayWidth(disp, scrn)) ||
(newimage->height > DisplayHeight(disp, scrn))) {
opt->info.zoom.x= opt->info.zoom.y=
- (newimage->width - DisplayWidth(disp, scrn) >
- newimage->height - DisplayHeight(disp, scrn) ?
+ ((int)newimage->width - DisplayWidth(disp, scrn) >
+ (int)newimage->height - DisplayHeight(disp, scrn) ?
(float)DisplayWidth(disp, scrn) / (float)newimage->width * 100.0 :
(float)DisplayHeight(disp, scrn) / (float)newimage->height * 100.0);
}
--- End Message ---
--- Begin Message ---
Source: xloadimage
Source-Version: 4.1-22
We believe that the bug you reported is fixed in the latest version of
xloadimage, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 506343@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Dominik George <nik@naturalnet.de> (supplier of updated xloadimage package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 02 Oct 2013 19:37:32 +0200
Source: xloadimage
Binary: xloadimage
Architecture: source amd64
Version: 4.1-22
Distribution: unstable
Urgency: low
Maintainer: Dominik George <nik@naturalnet.de>
Changed-By: Dominik George <nik@naturalnet.de>
Description:
xloadimage - Graphics file viewer under X11
Closes: 381382 506343 527575
Changes:
xloadimage (4.1-22) unstable; urgency=low
.
* Change maintainer to myself. (Closes: #527575)
* Re-license d/r under GPL-2+ as per the custom license
given by the original author.
* Fix build log checks.
- make build system respect all hardening flags.
- fix implicit declaration
* Do not resize images smaller than the screen with -shrink
(David Frey). (Closes: #381382)
* Fix -fullscreen behaviour for special gemoetry cases
(Anton Khirnov). (Closes: #506343)
* Replace hyphens by correct minus signs for options and others
in *.man.
* Builds with both libtiff4-dev and libtiff5-dev.
Checksums-Sha1:
d79eab1f4d704824b364f3522da7e4e87324f092 1768 xloadimage_4.1-22.dsc
0a8ee9b185702750706f68e4a34e086873f17690 596021 xloadimage_4.1.orig.tar.gz
69439018fdbd61a6ab0db4672633166fac6330a6 86668 xloadimage_4.1-22.debian.tar.gz
558a5a50aa351ba417034a6e5ce6337cc9735007 116352 xloadimage_4.1-22_amd64.deb
Checksums-Sha256:
14744e2491729892a922547bcdfc76501030b1d9ca9c67cf05062ee4c1f2a134 1768 xloadimage_4.1-22.dsc
400bc7d84dcfb3265a7a1ce51819679dc3adaeda231514bd89b0f932b78ff5c4 596021 xloadimage_4.1.orig.tar.gz
cdfa0340de744ae74a8ceccfc637c834cbcb82da5ade0937d1129103fc440003 86668 xloadimage_4.1-22.debian.tar.gz
f816db2f22d1bb9a36322159f747060d01d2eab097b2d1d537ea16d89af8426c 116352 xloadimage_4.1-22_amd64.deb
Files:
f6ae0105698619ffbb053b3e130ed461 1768 graphics optional xloadimage_4.1-22.dsc
7331850fc04056ab8ae6b5725d1fb3d2 596021 graphics optional xloadimage_4.1.orig.tar.gz
4ed90bd39a4b9ea722206708b6ea38cb 86668 graphics optional xloadimage_4.1-22.debian.tar.gz
fc565b6650bd82d9fac0be05da2ab604 116352 graphics optional xloadimage_4.1-22_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
iQIcBAEBCAAGBQJSZRzNAAoJEHQmOzf1tfkTTA0P/R89KMZyQSB7VHcht971ZHQq
wN2fUna0mBiuZ0GsYerakxLCq5U9aiy3s9chJPJsIinWZWZaKuqzaoo8DKtUE+DQ
22B82LWwifAofI5UAQwJJNmGj1YDuh+76EhTFzNqVZjf+iXq3Ez791wHvYcdZIxv
MCrVgRwXwWtNuONiv5lsUOuasFkh0mTHjMateJI71mDF173gNhDzkrERzOWTnZPt
MsakPRCg6MalOmYKQD3+s2tziDgeSxOtiS1TQc0oHzv98HSYivIUkK/tadEp7ZXu
G+AcKOgjaw+ED/xvhJXpTE/taETeRjHA8cTakVv8cmhg6hmDMImMR/h3lz8VrqMB
G0P+zfZrUfv+WNHZdb9rP4cAYTrs83mvwCjwUFjM8QehbFIn7Hlbn02EziOWYD2C
E/+TinsxP8E8xWLg/nUc2ZC2fveDcn8ivP8iSvsO2anfg925cJjOMVrZ2tEbMh7z
CuQTMoW5qYfyDOs/d677fkqXCj+zfd+avWyxxtkfF0Ds4zXI90eEDEg1jJRYiDo+
t8LiXTvWjdqafVY0R9zxcvbx+JK9lhu8fpTiGu4DE8FdWjO8qd+7hHkYYI3KEHBG
+R6/6VMt9OmQV/sMlkrDRL92gUGDkrbW+mCFjWzqROC59xjpFuRYAtCOkCe1wFFy
UxnHrPxevDpqU1RpeKtP
=jWgM
-----END PGP SIGNATURE-----
--- End Message ---