On 2021-06-19 18 h 21, Emmanuel Arias wrote: > Hello everybody, > > I want to tell you that I push to salsa an advances of poetry packaging. > > Now, we have a complete package of poetry, so I'm requesting some more > experienced reviewers. Sorry, I said I would do this but it took me some time to actually do it :) Thanks for working on poetry, it's 100% going to make our lives easier. I have not read the upstream code, so I might be missing things... That's the kind of thing I only do when a package is ready to be sponsored. Here are my comments: 1. d/control: You haven't set the Python Team either in Maintainer or Uploaders. --------------------------------------------------------------------- 2. d/control: If you require specific dependencies, you should make it clear in d/control. It's the kind of thing that helps a lot if people decide to backport it. --------------------------------------------------------------------- 3. tests/repositories/fixtures This directory contains a bunch of tarballs from other projects. I'm not sure what should be done with this, as I guess they are used in the testsuite.... My first reflex would be to exclude them from the imported tarball and disable the tests that require them, but I don't know how much of the testsuite depends on those tarballs. Maybe someone else from the team can chime-in? --------------------------------------------------------------------- 4. d/tests There are no autopkgtests. This being a large project that's kinda hard to package, I don't really mind for now. I think it's fair to wait to have at least 1 version in unstable before working on that. --------------------------------------------------------------------- 5. d/rules Isn't the step in execute_after_dh_auto_install better suited in execute_after_dh_clean instead? At least, it seems to me you're cleaning the ./foo dir you patched in. --------------------------------------------------------------------- 6. Lintian: W: python3-poetry: no-manual-page usr/bin/poetry Again, not something that needs to be fixed, but each subcommand of poetry should probably get a man page: https://python-poetry.org/docs/cli/ I looked at the code and I have no idea how this website is built (they don't use sphinx). It seems like they do something manual? https://github.com/python-poetry/poetry/issues/3382 Anyway, here's an example of how I added man pages to a program with multiple commands: https://github.com/spl0k/supysonic/tree/master/docs/man --------------------------------------------------------------------- Overall it's very good! The trickiest part to fix will likely be #3 :S > I need to skip some tests because use a non versioned python, so that > give me some troubles like "python don't exist". > > Also, there're some package (or package version) that aren't in Debian > yet. So, to save your time looking which are them I tell you that I run > the buildpackage in this way: > > ``` > > gbp buildpackage --git-ignore-new > --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-cleo_0.8.1-1_all.deb > --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-httpretty_1.0.5-0.1_all.deb > --extra-package=/home/eamanu/Debian/DEPENDENCIES/python3-pkginfo_1.7.0-1_all.deb This package has not been updated on Salsa, or at least, I couldn't find version 1.7.0-1 anywhere. Maybe you forgot to push? I'm getting test failures on tests/inspection/test_info.py, but I'm taking for granted it's because I don't have the right version. -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ Louis-Philippe Véronneau ⢿⡄⠘⠷⠚⠋ pollo@debian.org / veronneau.org ⠈⠳⣄
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature