[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1024367: In 4.9.1, the example uses not recommended install -s



On Fri, Nov 18, 2022 at 02:14:32PM +0100, Enrico Zini wrote:
> Package: debian-policy
> Version: 4.6.1.1
> Severity: normal
> 
> Hello, and thank you for maintaining the Policy!
> 
> Policy paragraph 4.9.1 has an example debian/rules which contains these
> lines:
> 
>    INSTALL_PROGRAM = $(INSTALL) -p    -o root -g root  -m  755
> 
>    ifeq (,$(filter nostrip,$(DEB_BUILD_OPTIONS)))
>        INSTALL_PROGRAM += -s
>    endif
> 
> However, paragraph 10.1 recommends against it:
> 
>    It is not recommended to strip binaries by passing the "-s" flag to
>    "install", because this fails to remove .comment and .note sections,
>    and also prevents the automatic creation of dbgsym binary packages by
>    tools like "dh_strip".
> 
> I would personally prefer if the example built on debhelper. If the
> intention is to show what are the expectations at a lower level then
> I wish the example had a comment saying "This snippet serves to explain
> what are the expectations as a lower level. You usually want to use
> debhelper instead"

I know it is not what you are after, but maybe it is time to fix install -s ?

dh_strip only work if the upstream 'make install' did not already
strip the binaries by using install -s itself. So packagers need to work
around it each time.

Cheers,
-- 
Bill. <ballombe@debian.org>

Imagine a large red swirl here. 


Reply to: