Bug#690717: libreoffice-common: bashism in /bin/sh script

[Rene Engelhard <rene@debian.org>]

Hi,

On Tue, Oct 16, 2012 at 12:55:55PM -0500, Raphael Geissert wrote:
> While performing an archive wide checkbashisms (from the 'devscripts' 
> package) check I've found your package containing a /bin/sh script making 
> use of a bashism.
> 
> checkbashisms' output:
> >possible bashism in ./usr/lib/libreoffice/program/soffice line 160 (should be 
> >word 2>&1):
> >    exec &>valgrind.log
> 
> Not using bash (or a Debian Policy conformant shell interpreter which 
> doesn't provide such an extra feature) as /bin/sh is likely to lead to 
> errors or unexpected behaviours.

Yes, but this part is inside a

# valgrind --log-file=valgrind.log does not work well with --trace-children=yes
if [ -n "$VALGRINDCHECK" -a -z "$VALGRIND" ] ; then
    echo "redirecting the standard and the error output to valgrind.log"
    exec &>valgrind.log
fi

so it only affects people who want to valgrind it... (who should know
how to fix it then anyways.)

Anyway, thanks, will add (and will commit the fix upstream).

Regards

Rene