[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1058582: The build tests are not enabled in the Debian package



Package: roc-toolkit
Version: 0.3.0+dfsg-4
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch

I'm was looking at libroc for Ubuntu since it's a new depends for pipewire and noticed that upstream provide tests which aren't enable in the package build. The attached patch make the tests run as part of the package build, I've testing it in a ppa and seems to work as expected
https://launchpadlibrarian.net/702261581/buildlog_ubuntu-noble-amd64.roc-toolkit_0.3.0+dfsg-4ubuntu1~build1_BUILDING.txt.gz

```
   debian/rules override_dh_auto_test
...
python3 scripts/scons_helpers/timeout-run.py 300 bin/x86_64-pc-linux-gnu/roc-test-core
..................................................
..................................................
..................
OK (118 tests, 118 ran, 86418 checks, 0 ignored, 0 filtered out, 11 ms)
```

It would be nice if the tests were also enabled in Debian

Cheers,
Sébastien Bacher
diff -Nru roc-toolkit-0.3.0+dfsg/debian/changelog roc-toolkit-0.3.0+dfsg/debian/changelog
--- roc-toolkit-0.3.0+dfsg/debian/changelog	2023-12-02 09:58:05.000000000 +0100
+++ roc-toolkit-0.3.0+dfsg/debian/changelog	2023-12-12 21:03:29.000000000 +0100
@@ -1,3 +1,9 @@
+roc-toolkit (0.3.0+dfsg-5) UNRELEASED; urgency=medium
+
+  * Enable build tests
+
+ -- Sebastien Bacher <seb128@ubuntu.com>  Tue, 12 Dec 2023 21:03:29 +0100
+
 roc-toolkit (0.3.0+dfsg-4) unstable; urgency=medium
 
   * Restrict Build-Deps on libunwind-dev only on supported architectures
diff -Nru roc-toolkit-0.3.0+dfsg/debian/control roc-toolkit-0.3.0+dfsg/debian/control
--- roc-toolkit-0.3.0+dfsg/debian/control	2023-12-02 09:58:05.000000000 +0100
+++ roc-toolkit-0.3.0+dfsg/debian/control	2023-12-12 21:03:29.000000000 +0100
@@ -5,6 +5,7 @@
 Uploaders: Dylan Aïssi <daissi@debian.org>
 Build-Depends: debhelper-compat (= 13),
                gengetopt,
+               libcpputest-dev,
                libpulse-dev,
                libsox-dev,
                libspeexdsp-dev,
diff -Nru roc-toolkit-0.3.0+dfsg/debian/rules roc-toolkit-0.3.0+dfsg/debian/rules
--- roc-toolkit-0.3.0+dfsg/debian/rules	2023-12-02 09:58:05.000000000 +0100
+++ roc-toolkit-0.3.0+dfsg/debian/rules	2023-12-12 21:03:29.000000000 +0100
@@ -2,7 +2,7 @@
 
 export DEB_BUILD_MAINT_OPTIONS=hardening=+all
 
-SCONS_BUILD_FLAGS = --libdir=/usr/lib/$(DEB_HOST_MULTIARCH) --disable-openfec
+SCONS_BUILD_FLAGS = --libdir=/usr/lib/$(DEB_HOST_MULTIARCH) --disable-openfec --enable-tests
 
 ifneq (,$(filter alpha hurd-amd64 hurd-i386 m68k sparc64 x32,$(DEB_HOST_ARCH)))
 SCONS_BUILD_FLAGS += --disable-libunwind
@@ -14,5 +14,8 @@
 override_dh_auto_build:
 	scons ${SCONS_BUILD_FLAGS}
 
+override_dh_auto_test:
+	scons ${SCONS_BUILD_FLAGS} test/roc_core
+
 override_dh_auto_install:
 	scons ${SCONS_BUILD_FLAGS} install DESTDIR=debian/tmp

Reply to: