[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#962650: marked as done (libcamera: API and ABI appear to be changing without a SONAME bump)

Your message dated Wed, 19 Oct 2022 14:08:12 +0100
with message-id <d44f997e-e55d-6bc6-81a1-4963ec743cab@collabora.co.uk>
and subject line Re: libcamera now maintaines proper sonames
has caused the Debian Bug report #962650,
regarding libcamera: API and ABI appear to be changing without a SONAME bump
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
962650: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=962650
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: libcamera
Version: 0~git20200417+35269f0-2
Severity: important
Tags: upstream

d4f81217 "New upstream version 0~git20200513+924778e" contains ABI breaks
in headers that appear to be public, for example the ones quoted below.
(I haven't looked any further back in history.)

If this library cannot be Policy §8.1-compliant because its ABI
is not yet stable, it should probably be moved to experimental, or
distributed as a static-only library for now, or (as a last resort)
given a Debian-specific SONAME.

Please increase the severity of this bug report to serious if this is
indeed an ABI break: it certainly shouldn't be going into testing with
an unstable ABI.

Thanks,
    smcv

diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h
index 18142dc..b3cbea3 100644
--- a/include/libcamera/stream.h
+++ b/include/libcamera/stream.h
@@ -42,6 +42,7 @@ struct StreamConfiguration {

        PixelFormat pixelFormat;
        Size size;
+       unsigned int stride;

        unsigned int bufferCount;

diff --git a/include/ipa/ipa_interface.h b/include/ipa/ipa_interface.h
index e65844b..dc9fc71 100644
--- a/include/ipa/ipa_interface.h
+++ b/include/ipa/ipa_interface.h
@@ -63,13 +88,15 @@ struct ipa_callback_ops {
 struct ipa_context_ops {
        void (*destroy)(struct ipa_context *ctx);
        void *(*get_interface)(struct ipa_context *ctx);
-       void (*init)(struct ipa_context *ctx);
+       void (*init)(struct ipa_context *ctx,
+                    const struct ipa_settings *settings);
        int (*start)(struct ipa_context *ctx);
        void (*stop)(struct ipa_context *ctx);
        void (*register_callbacks)(struct ipa_context *ctx,
                                   const struct ipa_callback_ops *callbacks,
                                   void *cb_ctx);
        void (*configure)(struct ipa_context *ctx,
+                         const struct ipa_sensor_info *sensor_info,
                          const struct ipa_stream *streams,
                          unsigned int num_streams,
                          const struct ipa_control_info_map *maps,

--- End Message ---
--- Begin Message --- 
Source: libcamera
Source-Version: 0.0.1-1
Done: Andrej Shadura <andrewsh@debian.org>

On Fri, 14 Oct 2022 15:57:02 +0300 Rafael Diniz <rafael@riseup.net> wrote:
Upstream libcamera now properly sets soname version and bumps it for ABI changes. 

Relevant commits in upstream:


Thanks! Now that 0.0.1 is packaged, I’ll close this bug.

--
Cheers,
  Andrej

--- End Message ---
Reply to: