[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#929642: marked as done (pd-flext FTCBFS: abuses AC_CHECK_FILE)

Your message dated Wed, 11 Sep 2019 13:35:01 +0000
with message-id <E1i82lx-0000jt-Fu@fasolo.debian.org>
and subject line Bug#929642: fixed in pd-flext 0.6.0+git20161101.1.01318a94-4
has caused the Debian Bug report #929642,
regarding pd-flext FTCBFS: abuses AC_CHECK_FILE
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
929642: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=929642
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: pd-flext
Version: 0.6.0+git20161101.1.01318a94-3
Tags: patch upstream
User: helmutg@debian.org
Usertags: rebootstrap

pd-flext fails to cross build from source, because it abuses
AC_CHECK_FILE for finding development files such as headers. The macro
is meant to locate files on the host system, but here it is being used
to search the build system. For that use, a simple "test -f" is better
suited. The attached patch makes pd-flext cross buildable. Please
consider applying it.

Helmut

--- pd-flext-0.6.0+git20161101.1.01318a94.orig/configure.ac
+++ pd-flext-0.6.0+git20161101.1.01318a94/configure.ac
@@ -33,7 +33,7 @@
 	[
 		if test $win; then
 # LATER: shouldn't we use AC_CHECK_LIB([pd]) ?
-		 AC_CHECK_FILE([$withval/pd.dll],,AC_MSG_ERROR([Cannot find $withval/pd.dll]))	
+		 AS_IF([test -f "$withval/pd.dll"],,AC_MSG_ERROR([Cannot find $withval/pd.dll]))	
 		fi
 		LIBDIRS="$LIBDIRS $withval"
 	],
@@ -47,8 +47,8 @@
 if test $SYSTEM == max; then
 	AC_DEFINE(FLEXT_SYS,1)
 # check for MaxAPI.h in pd folder
-	AC_CHECK_FILE([$sdkdir/max-includes/MaxAPI.h],,AC_MSG_ERROR([Cannot find $sdkdir/max-includes/MaxAPI.h]))
-	AC_CHECK_FILE([$sdkdir/max-includes/MaxAudioAPI.h],,AC_MSG_ERROR([Cannot find $sdkdir/max-includes/MaxAudioAPI.h]))
+	AS_IF([test -f "$sdkdir/max-includes/MaxAPI.h"],,AC_MSG_ERROR([Cannot find $sdkdir/max-includes/MaxAPI.h]))
+	AS_IF([test -f "$sdkdir/max-includes/MaxAudioAPI.h"],,AC_MSG_ERROR([Cannot find $sdkdir/max-includes/MaxAudioAPI.h]))
 	INCLUDEDIRS="$INCLUDEDIRS $sdkdir/max-includes $sdkdir/msp-includes"
 
 elif test $SYSTEM == pd; then
@@ -57,7 +57,7 @@
 
 	AC_DEFINE(FLEXT_SYS,2)
 # check for g_canvas.h in pd folder
-	AC_CHECK_FILE([$sdkdir/g_canvas.h],,AC_MSG_ERROR([Cannot find $sdkdir/g_canvas.h]))
+	AS_IF([test -f "$sdkdir/g_canvas.h"],,AC_MSG_ERROR([Cannot find $sdkdir/g_canvas.h]))
 	INCLUDEDIRS="$INCLUDEDIRS $sdkdir"
 
 	if test $win; then
@@ -71,7 +71,7 @@
 AC_ARG_WITH(atomic_ops,
 	AC_HELP_STRING(--with-atomic_ops,[path to atomic_ops library (needed for gcc version < 4.1 on non-i386 cpus)]),
 	[
-	    AC_CHECK_FILE([$withval/atomic_ops.h],,AC_MSG_ERROR([Cannot find $withval/atomic_ops.h]))	
+	    AS_IF([test -f "$withval/atomic_ops.h"],,AC_MSG_ERROR([Cannot find $withval/atomic_ops.h]))	
 		INCLUDEDIRS="$INCLUDEDIRS $withval"
         AC_DEFINE(USE_ATOMIC_OPS)
 	]
@@ -80,7 +80,7 @@
 AC_ARG_WITH(stkdir,
 	AC_HELP_STRING(--with-stkdir,[path to STK headers]),
 	[
-	    AC_CHECK_FILE([$withval/Stk.h],,AC_MSG_ERROR([Cannot find $withval/Stk.h]))	
+	    AS_IF([test -f "$withval/Stk.h"],,AC_MSG_ERROR([Cannot find $withval/Stk.h]))	
 		stkdir=$withval
 		INCLUDEDIRS="$INCLUDEDIRS $withval"
 	]
@@ -91,7 +91,7 @@
 AC_ARG_WITH(sndobjdir,
 	AC_HELP_STRING(--with-sndobjdir,[path to SndObj headers]),
 	[
-		AC_CHECK_FILE([$withval/SndObj.h],,AC_MSG_ERROR([Cannot find $withval/SndObj.h]))
+		AS_IF([test -f "$withval/SndObj.h"],,AC_MSG_ERROR([Cannot find $withval/SndObj.h]))
 		sndobjdir=$withval
 		INCLUDEDIRS="$INCLUDEDIRS $withval"
 	]

--- End Message ---
--- Begin Message --- 
Source: pd-flext
Source-Version: 0.6.0+git20161101.1.01318a94-4

We believe that the bug you reported is fixed in the latest version of
pd-flext, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 929642@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org> (supplier of updated pd-flext package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 11 Sep 2019 15:05:45 +0200
Source: pd-flext
Architecture: source
Version: 0.6.0+git20161101.1.01318a94-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org>
Closes: 929642
Changes:
 pd-flext (0.6.0+git20161101.1.01318a94-4) unstable; urgency=medium
 .
   [ Ondřej Nový ]
   * Use debhelper-compat instead of debian/compat
 .
   [ IOhannes m zmölnig ]
   * Update autotools-patch to not abuse AC_CHECK_FILE any more.
     Thanks to Helmut Grohne <helmut@subdivi.de> (Closes: #929642)
   * Added license-boilerplate to debian/Makefile.flext
   * Specify that building this package doesn't require "root" powers
   * Bump dh-compat to 12
   * Bump standards version to 4.4.0
Checksums-Sha1:
 411a50dc0c815d635e87fbd5a322d0e21cf45245 2488 pd-flext_0.6.0+git20161101.1.01318a94-4.dsc
 e7e30ddc0d25124756e3ec7aedc9fc233a06b471 8008 pd-flext_0.6.0+git20161101.1.01318a94-4.debian.tar.xz
Checksums-Sha256:
 0d9d7a3349916d4efc9648f4569c7b05565019758d5fc79257c379ffe227bfef 2488 pd-flext_0.6.0+git20161101.1.01318a94-4.dsc
 4c08dea19a8917a7a5add23093bcf51c46b0de598bc60ae05628d67ac735d806 8008 pd-flext_0.6.0+git20161101.1.01318a94-4.debian.tar.xz
Files:
 f358177a071d07852c3773f62b1cdc04 2488 libs optional pd-flext_0.6.0+git20161101.1.01318a94-4.dsc
 80700a96326a0005ce1969b2dd7d2d94 8008 libs optional pd-flext_0.6.0+git20161101.1.01318a94-4.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQJQBAEBCAA6FiEEdAXnRVdICXNIABVttlAZxH96NvgFAl148lQcHGpvaGFubmVz
Lnptb2VsbmlnQGt1Zy5hYy5hdAAKCRC2UBnEf3o2+MuYEACDexN+ZZQZCS1aiKge
Cx/8tl3+P/9GcX1D437Uw76yGZX/yuCiQbb1PyuVZT6dsscqh9beDUmQL33e53t+
gIlGinaWca9CGJG8QzckPa3lurY3YjAk0CGfHRTcXNKdzrzNjrHOcfpa2bDbO3Ks
lt9FJw8F0gwn0UhN1ZMiCudvtYlIQgfLjMrxiNvsW6OOe5Qr/E33xwaQuv65x523
4NbmQr4ypl/KBhioLjw/FNuch49ErA/GQM3L6pVTYQBVgflhc0aGLP55wNjaJLMq
PXDgR99wW1Up/qN81nV579NJ0+WsarsLz8s2U+AS+6m+VZIx2ZyGQ8Tf7yJQRPzK
ckvvb2JNDq66OAQGJtl6XNJ7DgwXSno5Jk1305oj1qjSA1QfMiyi9eeiDGhm2TiS
5OBn6niTz8Duxp6cMRLwy3t5++1JDnn+Kg7EKVzZGlaNWGycznWr/XEXPOSOoesb
lhPGA5CP3YJHGpmMCzw3TtQ7eEcu7tOmI8gOPnO/dHSyNuAaUmTNOTWsKfHIkz+0
FW8iwOpjea9YLeYpk2Z6DWzQOBLFuOI4ar/eIkimlWkIi4oRj1gpmDcgF2XwzfbT
h0ItrNixINBV7q4NjnvqRVQfzm8XenBuGQQearX1Y/8g8QLp0aJLLIb7LJ/5rGGq
dNtXOOjFtqUmQN1TJWYqYOWrRg==
=AAOJ
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: