package: csound
severity: important
justification: Stretch regression with no work around without code
changes
version: 1:6.12.2~dfsg-3
tags: patch, fixed-upstream, upstream
Hi. In https://github.com/csound/csound/issues/1119
I reported an issue.
In stretch, if you want to deal with a file that doesn't match the
orchestra sample rate in diskgrain, you have to do all the work in your
orchestra.
Between stretch and buster upstream tried to improve it but got a couple
of things wrong:
* Most seriously, they handle the initial file seek according to the
orchestra sr not the file sr. So there will be a jump of
uncontrollable length when the first file buffer is exausted.
* They scale the pitch but not the pointer read rate, so the orchestra
still has to know about the gap.
This is fixed in f23c45efcef upstream.
I confirmed that code change works against the upstream code base and
the Debian code base.
Thanks for such a thorough bug report.
I think this is self-contained enough to warrant a stable upload. One thing that needs checking is if the move of find_file.h has any impact. I would suggest not applying that part just to be safe. Another thing to check would be if syncgrain and syncloop need a similar change, as noted by Victor.
I'd like to try and get an unblock to get this into buster. I want your
support obviously before trying to do that. I'm happy to do everything
(prepare a package; upload; file an unblock), simply write the unblock
justification, sit back and let you deal, or accept that you don't think
this is worth trying to get an unblock for.
My justification for the unblock is that it's a well-constrained change,
something that is possible in stretch is entirely impossible in the
current buster code, and there is an easy fix.