[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#923494: Please Recommend and dlopen libsdl2 rather than depending on it





On Sun, Mar 10, 2019 at 6:57 PM Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
2019-03-10 23:21 GMT+01:00, Reinhard Tartler <siretart@gmail.com>:
> On Sat, Mar 9, 2019 at 2:51 PM Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
>
>> Could you test the configure option "--disable-outdev=sdl2"?
>> Your report indicates it should fix your issue, I am not convinced but
>> if it fixes your issue, Debian should consider using it as the device
>> is mostly a (cheap) debug feature.

> Wouldn't that video break playback in 'ffplay'?

Can you elaborate why you think so?

By looking at https://sources.debian.org/src/ffmpeg/7:4.1.1-1/fftools/ffplay.c/, I see plenty of references to SDL, many of which aren't guarded by #ifdefs. Looks like SDL2 is a hard dependency for a functional ffplay.
 
> Can you elaborate what makes you think so?

Iirc, I was the only one speaking against its removal.

You mean dropping ffplay altogether? - I am having a hard time parsing that sentence.
But given that your avconv project never contained an sdl output
device I wonder what your expertise is here?


I believe we may mis-communicating here. AFAIUI, the original poster wanted to make SDL an optional dependency. Even if the debian package was compiled with '--disable-outdev=sdl2', wouldn't the 'ffmpeg' binary package still continue to depend on sdl2 libraries? - In that case we haven't won anything by this. I guess the debian package would in addition have to pass the --disable-sdl2 switch to configure, which to my understanding would prevent 'ffplay' from being compiled. I would consider that a regression.

What might work is disabling the avdevice outdev AND moving 'ffplay' to its own binary package.
 
-- 
regards,
    Reinhard

Reply to: