[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Build-Depends for a Python wrapper



On Mon, Dec 24, 2018 at 06:09:04PM -0800, Matthew Fernandez wrote:
> Hello Debian Mentors,
>
> I???m preparing to request a piece of software I maintain be made
> available on Debian and have been doing my homework trying to package
> it correctly.
>
> It???s a C++ binary, but comes with a Python wrapper for invoking it
> [0]. This script should run with either Python 2 or Python 3 and
> requires no non-standard modules, but I???m having trouble getting
> lintian to approve of it.
>
> In trying to pacify its warnings, I seem to keep causing new
> ones. The latest is missing-build-dependency-for-dh-addon which seemed
> straightforward, but I???m having trouble resolving it.
>
> Is it possible I???m just going about this the wrong way? You can see my
> current fumblings around in the dark for the light switch at [1]. I have
> not packaged something for Debian before, so apologies if this question
> is answered elsewhere and my search skills failed me. If you have any
> time to point me in the right direction, I would be very grateful.
>
> Thanks, Matthew
>
> [0]: https://github.com/Smattr/rumur/blob/packaging/debian/rumur/src/rumur-run
> [1]: https://github.com/Smattr/rumur/blob/packaging/debian/debian/control

Multiline Build-Depends

--- a/debian/control
+++ b/debian/control
@@ -2,7 +2,13 @@ Source: rumur
 Section: devel
 Priority: optional
 Maintainer: Matthew Fernandez <matthew.fernandez@gmail.com>
-Build-Depends: debhelper (>= 10), bison (>= 3.0), cmake (>= 3.1), dh-python, flex (>= 2.5.35), libgmp-dev, python (>= 2.7)
+Build-Depends: debhelper (>= 10)
+  , bison (>= 3.0)
+  , cmake (>= 3.1)
+  , dh-python
+  , flex (>= 2.5.35)
+  , libgmp-dev
+  , python (>= 2.7)
 Standards-Version: 3.9.8
 Homepage: https://github.com/Smattr/rumur
 Vcs-Git: https://github.com/Smattr/rumur.git
 



| 
| $ lintian --info ../rumur_2018.12.20_amd64.changes 
| E: rumur source: missing-build-dependency-for-dh-addon python3 => python3:any | python3-all:any | python3-dev:any | python3-all-dev:any
| N: 
| N:    The source package appears to be using a dh addon but doesn't build
| N:    depend on the package that actually provides it. If it uses it, it must
| N:    build depend on it.
| N:    
| N:    Severity: important, Certainty: possible
| N:    
| N:    Check: debhelper, Type: source
| N: 
| 


--- a/debian/control
+++ b/debian/control
@@ -9,6 +9,7 @@ Build-Depends: debhelper (>= 10)
   , flex (>= 2.5.35)
   , libgmp-dev
   , python (>= 2.7)
+  , python3
 Standards-Version: 3.9.8
 Homepage: https://github.com/Smattr/rumur
 Vcs-Git: https://github.com/Smattr/rumur.git



Find attached two patches that you may apply with `git am  *.patch`


Groeten
Geert Stappers
-- 
Leven en laten leven
From 5e60bee663a51ff6c0a7145ba08855b7c8753c64 Mon Sep 17 00:00:00 2001
From: Geert Stappers <stappers@debian.org>
Date: Tue, 25 Dec 2018 11:15:37 +0100
Subject: [PATCH 1/2] Multilined the Build-Depends

To make further updates on build dependencies more diff friendly.
---
 debian/control | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index 550ce5b..d86c6bc 100644
--- a/debian/control
+++ b/debian/control
@@ -2,7 +2,13 @@ Source: rumur
 Section: devel
 Priority: optional
 Maintainer: Matthew Fernandez <matthew.fernandez@gmail.com>
-Build-Depends: debhelper (>= 10), bison (>= 3.0), cmake (>= 3.1), dh-python, flex (>= 2.5.35), libgmp-dev, python (>= 2.7)
+Build-Depends: debhelper (>= 10)
+  , bison (>= 3.0)
+  , cmake (>= 3.1)
+  , dh-python
+  , flex (>= 2.5.35)
+  , libgmp-dev
+  , python (>= 2.7)
 Standards-Version: 3.9.8
 Homepage: https://github.com/Smattr/rumur
 Vcs-Git: https://github.com/Smattr/rumur.git
-- 
2.20.1

From b1b7cb644a625bc20579cf83cb8da7f1a77c173e Mon Sep 17 00:00:00 2001
From: Geert Stappers <stappers@debian.org>
Date: Tue, 25 Dec 2018 11:29:23 +0100
Subject: [PATCH 2/2] Also build depend on python3

---
 debian/control | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/control b/debian/control
index d86c6bc..815075e 100644
--- a/debian/control
+++ b/debian/control
@@ -9,6 +9,7 @@ Build-Depends: debhelper (>= 10)
   , flex (>= 2.5.35)
   , libgmp-dev
   , python (>= 2.7)
+  , python3
 Standards-Version: 3.9.8
 Homepage: https://github.com/Smattr/rumur
 Vcs-Git: https://github.com/Smattr/rumur.git
-- 
2.20.1

Attachment: signature.asc
Description: PGP signature


Reply to: