Bug#790104: RFS: lightdm-gtk-greeter-settings/1.2.0-1 [ITP]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hi Christian,
Thanks for the thorough review!
On Mon, 05 Oct 2015 22:47:21 +0200 Christian Kastner <ckk@debian.org> wrote:
> d/control:
> - The frontend for git at anonscm.d.o has been changed from gitweb to
> git; please update Vcs-Browser URL accordingly
> - Developer's Reference §6.2.2 says that the synopsis is not a
> sentence, so you don't need to start it with a capital letter
> - synopsis / long description: GTK is spelled with all-caps, however
Done.
> - Depends seems to be missing Pango, going by PKG-INFO
Assuming this means gir1.2-pango-1.0, added.
>
> d/copyright:
> - The license appears to be GPL-3, not GPL-3+ (at least in the handful
> of files I checked). This also requires correction of the free-
> standing license block (the last paragraph)
I see. Ubuntu's packaging wrote the license as GPL-3+ for both the
packaging and the source, but I guess the license of the individual
files must prevail here. Fixed.
> - In the header, the field's name is "Source", not "Upstream-Source"
Done.
> - There's a formatting issue in the free-standing license text (line
> 27 is not indented)
I'm not sure what this means. Is it supposed to be indented to the width
of "X-Comment: "? That's what I did.
> d/lightdm-gtk-greeter-settings.lintian-overrides:
> - Instead of adding lintian override for the missing man page of
> lightdm-gtk-greeter-settings-pkexec, symlinking it to the
> manpage of lightdm-gtk-greeter-settings, as some other packages do
> for -pkexec files (eg: src:mate-system-tools), would be more useful
That's a better idea, done.
> d/rules:
> - You don't need a get-orig-source target for a mere uscan invocation.
> g-o-s is for cases in which downloading via uscan produces something
> that does _not_ match the orig tarball uploaded to the Debian
> archive: for example, when files have been removed from the original
> source (think: DFSG cleaning), or when you can only recreate the
> tarball by checking out from a repository
Removed, thanks.
>
> I'm happy to sponsor your package, but out of curiosity: have you tried
> pinging the lightdm-gtk-greeter maintainers? They could be interested in
> this package, and are probably in a much better position to assist you
> with issues related to this program than I am.
No, I'll do that now.
Best,
James
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCAAGBQJWGfl+AAoJEC7D9g3nHAudff0P/1WYusM98IcyaYtc9KN1wMr0
pcisB0uyqKkFjDG2FJ0DVZb+/vLCBw1QSg49GixIHjoVKSk/hBbB1OaAhfmbxVV3
wKpWYz+2axH7pzkshN2hkXPmUsWYfCLXk1rEYqnI4DmT1ez8tH1ioyM4dGlyUCMo
HFzNUOsKfZ+1xDbsuGJkVe2FmB38+uon4kZey30lyLFVeYI7B72+a12WxV4fb3sI
sMkUPUX+6/FiM33LrDlBbroil9/YAS2EjPHSDOfjhmd9SWL3R1yZ9jbziUAMIJcy
IRDWtx0iX2WQ6z4xj1PRDJFlqHqoUxrGGaqGcgFe/DlioixdKoVLeoCvtUZwIZ4h
cH5CB8h772mJvC/FebajgCAw7fZ1gvyqqgYhUJhipvWji7+nHEqB9cPN6r5LY+lx
t+zPJ/8Dyj1Q71rD3Pz7UGqBWu/NdGvqdoGkyYzCJW9o3yUmZguWcwtlenRaf7x+
gY10LfFaevLGe2bShkgkM3HQKbpkFJyLjrrg1O9bhr84C5YZ93rwZBaI2sFmA2h3
bv8E7L8CAsQuKTZCeibz9njwjZkS3IuA3LHdO3+hxLP30imydBdpcRFmx39kfvvo
fAWOk63LGgMHUmyUwfMURnpN/QrtMxTURrLAX619Xp9KIAftiQ5E01+WaPzitxxk
eqJXyZs4nfUnMvuI2wGE
=BhiE
-----END PGP SIGNATURE-----
Reply to: