Re: RFS : libdistlib-java
Hi Andreas,
Le 25/05/2020 à 23:12, Andreas Tille a écrit :
> Hi Pierre,
>
> On Mon, May 25, 2020 at 10:47:58PM +0200, Pierre Gruet wrote:
>> I have packaged libdistlib-java, which is a Java implementation of
>> several cdf, pdf, quantile and simulation functions from R, originally
>> written in C.
>>
> [...]
>>
>> Would it be possible to have a review? It would be precious, as this is
>> my first initial packaging!
>
> Looks pretty good. The only nitpicking comment would be that
> in d/changelog you are repeating the version number inside the
> text section. I left it as is but its a bit redundant.
>
Thanks for the review, the upload and this comment!
I shall avoid such redundancy next time.
> [...]
>
> Its uploaded now. Thanks a lot again
>
> Andreas.
>
>
Have a nice afternoon,
Best regards,
Pierre
Reply to: