[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#433612: Duplicate grub lines



Package: live-helper
Version: 1.0~a18-1
Severity: normal

--- Please enter the report below this line. ---
Recently the lh_binary_grub helper started adding 2 fake lines in the
grub menu. Looking at the code, this snipped catch my attention:

  DEFAULT_FLAVOUR="`echo ${LIVE_LINUX_FLAVOURS} | awk '{ print $1 }'`"
  DEFAULT_KERNEL="`basename chroot/boot/vmlinuz-*${DEFAULT_FLAVOUR}`"
  DEFAULT_INITRD="initrd.img-`echo ${DEFAULT_KERNEL} | sed -e 's/vmlinuz-//'`"
  
  Grub_live_entry "live" "${DEFAULT_KERNEL}" "${DEFAULT_INITRD}"
  Grub_live_entry "live (fail-safe mode)" "${DEFAULT_KERNEL}" "${DEFAULT_INITRD}" "${FAILSAFE}"
  
  for KERNEL in chroot/boot/vmlinuz-*
  do
          VERSION="`basename ${KERNEL} | sed -e 's/vmlinuz-//'`"
  
          Grub_live_entry "live, kernel ${VERSION}" "`basename ${DESTDIR_LIVE}`/`basename ${KERNEL}`" "`basename ${DESTDIR_LIVE}`/initrd.img-${VERSION}"
          Grub_live_entry "live, kernel ${VERSION} (fail-safe mode)" "`basename ${DESTDIR_LIVE}`/`basename ${KERNEL}`" "`basename ${DESTDIR_LIVE}`/initrd.img-${VERSION}" "${FAILSAFE}"
  done

IMO the for loop catches twice the default kernel image. I mean, it has already been added explicitly, so the for loops add it again. Moreover the former addition is different not only in the lable name, but also in the path!
And at least in my case the former does not work at all (points to a non existing path)

Cheers

--- System information. ---
Architecture: amd64
Kernel:       Linux 2.6.21.1-mactel

Debian Release: lenny/sid
  500 unstable        www.debian-multimedia.org 
  500 unstable        ftp.it.debian.org 
  500 testing         security.debian.org 

--- Package information. ---
Depends             (Version) | Installed
=============================-+-=============
cdebootstrap     (>= 0.3.15)  | 0.4.3
 OR debootstrap  (>= 0.3.3.2) | 1.0.0


-- 
Enrico Tassi




Reply to: