[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Git][lintian/lintian][master] Remove obsolete tag "package-supports-alternative-init-but-no-init.d-script"

Title: GitLab

Nilesh Patra pushed to branch master at lintian / lintian

Commits:

  • 579d080b
    by Gioele Barabucci at 2023-09-29T21:36:27+00:00 
    Remove obsolete tag "package-supports-alternative-init-but-no-init.d-script"

Debian policy Section 9.11 "Alternate init systems", the section
responsible for `package-supports-alternative-init-but-no-init.d-script`
has been deleted [1,2] and the check is thus no longer needed.

Rewrite the test to focus only on
`directory-in-etc-sv-directory-without-executable-run-script`.

[1] https://www.debian.org/doc/debian-policy/ch-opersys.html#alternate-init-systems
[2] https://salsa.debian.org/dbnpolicy/policy/-/commit/d9cfe27611e86cc5e1496d1db73d1ad2761a259c

13 changed files:

Changes:

  • lib/Lintian/Check/InitD.pm
    ... ... @@ -708,25 +708,6 @@ sub check_defaults {
    708 708 
     sub visit_installed_files {
    709 709 
         my ($self, $item) = @_;
    710 710
    711 
    -    # check for missing init.d script when alternative init system is present
    712 
    -
    713 
    -    if (   $item =~ m{etc/sv/(?<svc>[^/]+)/run$}
    714 
    -        || $item =~ m{(?<usr>usr/)?lib/systemd/system/(?<svc>[^/@]+)\.service})
    715 
    -    {
    716 
    -
    717 
    -        my ($usr, $service) = ($+{usr} // $EMPTY, $+{svc});
    718 
    -
    719 
    -        $self->pointed_hint(
    720 
    -            'package-supports-alternative-init-but-no-init.d-script',
    721 
    -            $item->pointer)
    722 
    -          unless $self->processable->installed->resolve_path(
    723 
    -            "etc/init.d/${service}")
    724 
    -          || $self->processable->installed->resolve_path(
    725 
    -            "${usr}lib/systemd/system/${service}.path")
    726 
    -          || $self->processable->installed->resolve_path(
    727 
    -            "${usr}lib/systemd/system/${service}.timer");
    728 
    -    }
    729 
    -
    730 711 
         if ($item =~ m{etc/sv/([^/]+)/$}) {
    731 712
    732 713 
             my $service = $1;

  • t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/build-spec/debian/bar.service → t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/build-spec/debian/bar.service

  • t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/build-spec/debian/control.in → t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/build-spec/debian/control.in

  • t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/build-spec/debian/install → t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/build-spec/debian/install

  • t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/build-spec/debian/rules → t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/build-spec/debian/rules

  • t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/build-spec/debian/run → t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/build-spec/debian/run

  • t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/build-spec/fill-values
    1 
    +Skeleton: upload-native
    2 
    +Testname: directory-in-etc-sv-directory-without-executable-run-script
    3 
    +Description: Check for directories in /etc/sv missing run script

  • t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/eval/desc
    1 
    +Testname: directory-in-etc-sv-directory-without-executable-run-script
    2 
    +Check: init-d

  • t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/eval/hints
    1 
    +directory-in-etc-sv-directory-without-executable-run-script (binary): directory-in-etc-sv-directory-without-executable-run-script etc/sv/foo/run [etc/sv/foo/]

  • t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/build-spec/fill-values deleted
    1 
    -Skeleton: upload-native
    2 
    -Testname: package-supports-alternative-init-but-no-init.d-script
    3 
    -Description: Check for daemon with missing init.d script

  • t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/eval/desc deleted
    1 
    -Testname: package-supports-alternative-init-but-no-init.d-script
    2 
    -Check: init-d

  • t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/eval/hints deleted
    1 
    -package-supports-alternative-init-but-no-init.d-script (binary): package-supports-alternative-init-but-no-init.d-script [lib/systemd/system/bar.service]
    2 
    -package-supports-alternative-init-but-no-init.d-script (binary): package-supports-alternative-init-but-no-init.d-script [etc/sv/foo/run]
    3 
    -package-supports-alternative-init-but-no-init.d-script (binary): directory-in-etc-sv-directory-without-executable-run-script etc/sv/foo/run [etc/sv/foo/]

  • tags/p/package-supports-alternative-init-but-no-init.d-script.tag deleted
    1 
    -Tag: package-supports-alternative-init-but-no-init.d-script
    2 
    -Severity: info
    3 
    -Check: init-d
    4 
    -See-Also: debian-policy 9.11
    5 
    -Explanation: The package provides daemon, but contains no init.d script
    6 
    - Packages that provide services (daemons), like cron daemon or web servers,
    7 
    - may provide init.d script for starting that services with sysvinit.
    8 
    - Optionally, packages can also provide integration with alternative init
    9 
    - systems.
    10 
    - .
    11 
    - Package in question provides integration with some alternative init system,
    12 
    - but corresponding init.d script is absent.
    13 
    - .
    14 
    - See <code>init-d-script</code>(5) for one of possible ways writing init.d scripts.

    • —
    View it on GitLab.
    You're receiving this email because of your account on salsa.debian.org. Manage all notifications · Help

    Reply to: