[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#512265: #512265: clarifying the intent of the bug report



Hi Felix,

On 2021-09-17 22:02, Felix Lechner wrote:
> Control: retitle -1 lintian: flag upstream tests missing from autopkgtest

> I agree with you, and picked yet another title. Please let me know
> what you think.

I still think the original intent was to encourage the maintainers to
run upstream tests during build. Thus I would suggest renaming the bug to:

    lintian: flag packages not running upstream build time tests

>> * lintian: Warn about unused autopkgtests
> 
> Upon reflection and refactoring the code [1] I do not think it can be
> implemented. With Test-Directory set to '.' all files in the source
> package are candidates, and would produce hints for not being used.

Sorry, I was not clear enough here. My suggestion here was to flag
packages not supplying autopkgtests although they could do so. For
example, Perl packages having tests under t/ directory, but somehow not
having autopkgtest at all.

>> * lintian: Warn about unused build time tests
> 
> I am not sure how to implement the original request. Your suggestions
> are welcome.

Example of a general rule: some packages have debian/rules file with
override_dh_auto_test followed by an empty line. This means upstream
tests would be run by debhelper, but for some reason they are turned off.

And there are buildsystem-specific rules. For example, for Maven
packages, a line

    maven.test.skip=true

in debian/maven.properties means that upstream tests are ignored during
build.

> Thank you for figuring out the purpose of this report!

Thanks for prompt response!

> [1] https://salsa.debian.org/lintian/lintian/-/commit/7428997ded64b57ccf9a7c5874c683b7b8fd188e#02c42ce39affeca72ca4ed5d708e75a7bc945171_203_207

Best,
Andrius


Reply to: