[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#897157: lintian: Allow /usr/share/doc/$pkg/examples to be a symlink



* Adam D. Barratt <adam@adam-barratt.org.uk> [2018-05-01 12:01]:

On 2018-05-01 10:49, Rafael Laboissière wrote:

Why is this bug report tagged "moreinfo"?

Because the above commit isn't a "fix" for anything - it's a testcase to prove that the existing code already does what you requested, with no changes.

The "moreinfo" tag will therefore be requesting more details about your failing case - most likely access to copies of the affected .deb files - in order to see why it appears not to be working for you.

Thanks for the clarification.

I use a Lintian package built from Git (version 2.5.85, commit e86bfd5) and I still get the following warning when building octave-zeromq:

 P: octave-zeromq source: package-does-not-install-examples inst/examples/

I am attaching below the full Lintian output, as well as the output of the debc command. In this last one, I see:

 lrwxrwxrwx root/root         0 2018-04-29 17:06 ./usr/share/doc/octave-zeromq/examples -> ../../octave/packages/zeromq-1.3.0/examples

FYI, the octave-zeromq package can be built with git-buildpackage from:

 https://salsa.debian.org/pkg-octave-team/octave-zeromq.git

I confirm that when the patch attached below is applied oto the current Git HEAD, the warning goes away.

Best,

Rafael
P: octave-zeromq source: package-does-not-install-examples inst/examples/
X: octave-zeromq source: upstream-metadata-file-is-missing
P: octave-zeromq source: debian-watch-does-not-check-gpg-signature
I: octave-zeromq: spelling-error-in-binary usr/lib/x86_64-linux-gnu/octave/packages/zeromq-1.3.0/x86_64-pc-linux-gnu-api-v51/zeromq.oct recieved received
I: octave-zeromq: hardening-no-bindnow usr/lib/x86_64-linux-gnu/octave/packages/zeromq-1.3.0/x86_64-pc-linux-gnu-api-v51/zeromq.oct
P: octave-zeromq: no-upstream-changelog
octave-zeromq-dbgsym_1.3.0-2_amd64.deb
--------------------------------------
 new Debian package, version 2.0.
 size 3959136 bytes: control archive=536 bytes.
     384 bytes,    12 lines      control              
     106 bytes,     1 lines      md5sums              
 Package: octave-zeromq-dbgsym
 Source: octave-zeromq
 Version: 1.3.0-2
 Auto-Built-Package: debug-symbols
 Architecture: amd64
 Maintainer: Debian Octave Group <team+pkg-octave-team@tracker.debian.org>
 Installed-Size: 3991
 Depends: octave-zeromq (= 1.3.0-2)
 Section: debug
 Priority: optional
 Description: debug symbols for octave-zeromq
 Build-Ids: 64ab60e5902d3d6a56fbfca6527f54660ac82830
drwxr-xr-x root/root         0 2018-04-29 17:06 ./
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/lib/
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/lib/debug/
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/lib/debug/.build-id/
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/lib/debug/.build-id/64/
-rw-r--r-- root/root   4076328 2018-04-29 17:06 ./usr/lib/debug/.build-id/64/ab60e5902d3d6a56fbfca6527f54660ac82830.debug
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/share/
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/share/doc/
lrwxrwxrwx root/root         0 2018-04-29 17:06 ./usr/share/doc/octave-zeromq-dbgsym -> octave-zeromq

octave-zeromq_1.3.0-2_amd64.deb
-------------------------------
 new Debian package, version 2.0.
 size 63608 bytes: control archive=2216 bytes.
     851 bytes,    18 lines      control              
    4795 bytes,    53 lines      md5sums              
 Package: octave-zeromq
 Version: 1.3.0-2
 Architecture: amd64
 Maintainer: Debian Octave Group <team+pkg-octave-team@tracker.debian.org>
 Installed-Size: 310
 Depends: octave (>= 4.2.2), libc6 (>= 2.14), libgcc1 (>= 1:3.0), liboctave4, libomp5 (>= 0.20130412), libstdc++6 (>= 5.2), libzmq5 (>= 3.2.3+dfsg)
 Section: math
 Priority: optional
 Homepage: https://octave.sourceforge.io/zeromq/
 Description: ZeroMQ binding for Octave
  ZeroMQ is a library which extends the standard socket interfaces,
  providing an abstraction of asynchronous message queues, multiple
  messaging patterns, message filtering (subscriptions), seamless
  access to multiple transport protocols and more.  This package
  contains the binding to the ZeroMQ library for use in Octave, a
  scientific computation software.
  .
  This Octave add-on package is part of the Octave-Forge project.
drwxr-xr-x root/root         0 2018-04-29 17:06 ./
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/lib/
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/lib/x86_64-linux-gnu/
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/lib/x86_64-linux-gnu/octave/
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/lib/x86_64-linux-gnu/octave/packages/
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/lib/x86_64-linux-gnu/octave/packages/zeromq-1.3.0/
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/lib/x86_64-linux-gnu/octave/packages/zeromq-1.3.0/x86_64-pc-linux-gnu-api-v51/
-rw-r--r-- root/root      1516 2018-04-29 17:06 ./usr/lib/x86_64-linux-gnu/octave/packages/zeromq-1.3.0/x86_64-pc-linux-gnu-api-v51/PKG_ADD
-rwxr-xr-x root/root    211664 2018-04-29 17:06 ./usr/lib/x86_64-linux-gnu/octave/packages/zeromq-1.3.0/x86_64-pc-linux-gnu-api-v51/zeromq.oct
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/share/
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/share/doc/
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/share/doc/octave-zeromq/
-rw-r--r-- root/root       514 2017-12-28 07:42 ./usr/share/doc/octave-zeromq/README
-rw-r--r-- root/root       650 2018-04-29 17:06 ./usr/share/doc/octave-zeromq/changelog.Debian.gz
-rw-r--r-- root/root      1248 2018-04-24 16:39 ./usr/share/doc/octave-zeromq/copyright
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/share/octave/
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/share/octave/packages/
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/@octave_zeromq_socket/
-rw-r--r-- root/root      1078 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/@octave_zeromq_socket/close.m
-rw-r--r-- root/root      1481 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/@octave_zeromq_socket/get.m
-rw-r--r-- root/root      1745 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/@octave_zeromq_socket/set.m
-rw-r--r-- root/root      1017 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/ZMQ_DEALER.m
-rw-r--r-- root/root      1024 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/ZMQ_DONTWAIT.m
-rw-r--r-- root/root      1030 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/ZMQ_EVENTS.m
-rw-r--r-- root/root      1072 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/ZMQ_IDENTITY.m
-rw-r--r-- root/root      1005 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/ZMQ_PAIR.m
-rw-r--r-- root/root      1048 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/ZMQ_POLLIN.m
-rw-r--r-- root/root      1053 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/ZMQ_POLLOUT.m
-rw-r--r-- root/root       998 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/ZMQ_PUB.m
-rw-r--r-- root/root      1005 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/ZMQ_PULL.m
-rw-r--r-- root/root      1005 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/ZMQ_PUSH.m
-rw-r--r-- root/root      1036 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/ZMQ_RCVMORE.m
-rw-r--r-- root/root      1001 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/ZMQ_REP.m
-rw-r--r-- root/root      1003 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/ZMQ_REQ.m
-rw-r--r-- root/root      1017 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/ZMQ_ROUTER.m
-rw-r--r-- root/root      1018 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/ZMQ_SNDMORE.m
-rw-r--r-- root/root       999 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/ZMQ_SUB.m
-rw-r--r-- root/root      1059 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/ZMQ_SUBSCRIBE.m
-rw-r--r-- root/root      1121 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/ZMQ_TYPE.m
-rw-r--r-- root/root      1069 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/ZMQ_UNSUBSCRIBE.m
-rw-r--r-- root/root      8306 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/doc-cache
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/examples/
-rw-r--r-- root/root      1796 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/examples/doc-cache
-rw-r--r-- root/root      2189 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/examples/zmq_example1.m
-rw-r--r-- root/root      1414 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/examples/zmq_example2.m
-rw-r--r-- root/root      1391 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/examples/zmq_example3.m
-rw-r--r-- root/root      1639 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/examples/zmq_example4.m
-rw-r--r-- root/root      1272 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/iszmq.m
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/packinfo/
-rw-r--r-- root/root       343 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/packinfo/DESCRIPTION
-rw-r--r-- root/root       627 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/packinfo/INDEX
-rw-r--r-- root/root      1493 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/packinfo/NEWS
drwxr-xr-x root/root         0 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/test/
-rw-r--r-- root/root       123 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/test/bind.cc-tst
-rw-r--r-- root/root       174 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/test/close.cc-tst
-rw-r--r-- root/root        85 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/test/connect.cc-tst
-rw-r--r-- root/root       298 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/test/disconnect.cc-tst
-rw-r--r-- root/root       393 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/test/getsockopt.cc-tst
-rw-r--r-- root/root       783 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/test/globals.cc-tst
-rw-r--r-- root/root       196 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/test/poll.cc-tst
-rw-r--r-- root/root       580 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/test/properties.cc-tst
-rw-r--r-- root/root       268 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/test/recv.cc-tst
-rw-r--r-- root/root       235 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/test/send.cc-tst
-rw-r--r-- root/root       153 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/test/setsockopt.cc-tst
-rw-r--r-- root/root       450 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/test/socket.cc-tst
-rw-r--r-- root/root       271 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/test/unbind.cc-tst
-rw-r--r-- root/root       141 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/test/version.cc-tst
-rw-r--r-- root/root        48 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/test/zeromq.cc-tst
-rw-r--r-- root/root      1991 2018-04-29 17:06 ./usr/share/octave/packages/zeromq-1.3.0/zmq_test.m
lrwxrwxrwx root/root         0 2018-04-29 17:06 ./usr/share/doc/octave-zeromq/NEWS -> ../../octave/packages/zeromq-1.3.0/packinfo/NEWS
lrwxrwxrwx root/root         0 2018-04-29 17:06 ./usr/share/doc/octave-zeromq/examples -> ../../octave/packages/zeromq-1.3.0/examples

diff --git a/checks/cruft.pm b/checks/cruft.pm
index 0a4ab45af..8c19d0b40 100644
--- a/checks/cruft.pm
+++ b/checks/cruft.pm
@@ -1593,7 +1593,7 @@ sub _ships_examples {
         return 1 if $name =~ m{-examples$};
         my @files = $binpkg->info->sorted_index;
         return 1
-          if any { m{^usr/share/doc/(.+/)?examples/$} } @files;
+          if any { m{^usr/share/doc/(.+/)?examples/?$} } @files;
     }
     return;
 }

Reply to: