[lintian] 01/01: Clarify the meaning of the depends-on-build-essential-package-without-using-version tag by prefixing it with "build-". Thanks to Sven Joachim and Laurent Bigonville. (Closes: #892597)
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit fa9ce0ecba353dde40f40c282dce1daf209b236b
Author: Chris Lamb <lamby@debian.org>
Date: Sun Mar 11 18:08:09 2018 -0700
Clarify the meaning of the depends-on-build-essential-package-without-using-version tag by prefixing it with "build-". Thanks to Sven Joachim and Laurent Bigonville. (Closes: #892597)
---
checks/fields.desc | 6 +++---
checks/fields.pm | 2 +-
data/override/renamed-tags | 1 +
debian/changelog | 5 +++++
t/tests/fields-build-depends-general/desc | 2 +-
t/tests/fields-build-depends-general/tags | 2 +-
t/tests/legacy-relations/desc | 2 +-
t/tests/legacy-relations/tags | 4 ++--
8 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/checks/fields.desc b/checks/fields.desc
index 0630fb7..54b6584 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -672,12 +672,12 @@ Info: The restriction formula in the source relation includes an unknown build
and "pkg.<i>srcpkg</i>.<i>anything</i>".
Ref: https://wiki.debian.org/BuildProfileSpec#Registered_profile_names
-Tag: depends-on-build-essential-package-without-using-version
+Tag: build-depends-on-build-essential-package-without-using-version
Severity: important
Certainty: certain
Ref: policy 4.2
-Info: The package declares a depends on a build essential package without
- using a versioned depends. Packages do not have to build-depend on any
+Info: The package declares a build-depends on a build essential package
+ without using a versioned depends. Packages do not have to depend on any
package included in build-essential. It is the responsibility of anyone
building packages to have all build-essential packages installed. The
only reason for an explicit dependency on a package included in
diff --git a/checks/fields.pm b/checks/fields.pm
index 90356a7..e80ae24 100644
--- a/checks/fields.pm
+++ b/checks/fields.pm
@@ -1114,7 +1114,7 @@ sub run {
if ($d_pkg eq 'build-essential');
#<<< no tidy, tag name too long
- tag 'depends-on-build-essential-package-without-using-version',
+ tag 'build-depends-on-build-essential-package-without-using-version',
#>>>
"$d_pkg [$field: $part_d_orig]"
if ($known_build_essential->known($d_pkg)
diff --git a/data/override/renamed-tags b/data/override/renamed-tags
index d52e56a..aa87b61 100644
--- a/data/override/renamed-tags
+++ b/data/override/renamed-tags
@@ -2,6 +2,7 @@
debian-changelog-has-wrong-weekday => debian-changelog-has-wrong-day-of-week
debian-watch-may-check-gpg-signature => debian-watch-does-not-check-gpg-signature
dep5-file-paragraph-reference-header-paragraph => dep5-file-paragraph-references-header-paragraph
+depends-on-build-essential-package-without-using-version => build-depends-on-build-essential-package-without-using-version
fields-co-maintained-package-with-no-vcs-headers => fields-co-maintained-package-with-no-vcs-fields
package-install-apt-preferences => package-installs-apt-preferences
package-install-apt-sources => package-installs-apt-sources
diff --git a/debian/changelog b/debian/changelog
index 2a19e23..550a932 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -11,6 +11,11 @@ lintian (2.5.80) UNRELEASED; urgency=medium
package has explicit Build-Depends on dpkg-dev (>= 1.18.8) or
debhelper (>= 10.10). Thanks to Andreas Metzler for the report.
(Closes: #892549)
+ * checks/fields.{desc,pm}:
+ + [CL] Clarify the meaning of the
+ depends-on-build-essential-package-without-using-version tag by
+ prefixing it with "build-". Thanks to Sven Joachim and Laurent
+ Bigonville. (Closes: #892597)
* data/debhelper/*, data/common/dh_addons:
+ [CL] Refresh all debhelper data, correcting the entry for dh-scour.
diff --git a/t/tests/fields-build-depends-general/desc b/t/tests/fields-build-depends-general/desc
index a9884d4..4d43b77 100644
--- a/t/tests/fields-build-depends-general/desc
+++ b/t/tests/fields-build-depends-general/desc
@@ -12,7 +12,7 @@ Test-For:
build-depends-on-python-dev-with-no-arch-any
build-depends-on-versioned-berkeley-db
conflicting-negation-in-source-relation
- depends-on-build-essential-package-without-using-version
+ build-depends-on-build-essential-package-without-using-version
depends-on-packaging-dev
invalid-arch-string-in-source-relation
ored-build-depends-on-obsolete-package
diff --git a/t/tests/fields-build-depends-general/tags b/t/tests/fields-build-depends-general/tags
index 1350527..837ad02 100644
--- a/t/tests/fields-build-depends-general/tags
+++ b/t/tests/fields-build-depends-general/tags
@@ -1,10 +1,10 @@
E: fields-build-depends-general source: build-conflicts-with-build-dependency bd-conflict
E: fields-build-depends-general source: build-depends-on-build-essential build-depends
+E: fields-build-depends-general source: build-depends-on-build-essential-package-without-using-version make [build-depends: make]
E: fields-build-depends-general source: build-depends-on-essential-package-without-using-version build-depends: bash
E: fields-build-depends-general source: build-depends-on-metapackage build-depends: xorg-dev
E: fields-build-depends-general source: build-depends-on-non-build-package build-depends: java-propose-classpath
E: fields-build-depends-general source: conflicting-negation-in-source-relation build-depends: baz [i386 !amd64]
-E: fields-build-depends-general source: depends-on-build-essential-package-without-using-version make [build-depends: make]
E: fields-build-depends-general source: invalid-arch-string-in-source-relation all [build-depends: foo [all]]
E: fields-build-depends-general source: invalid-arch-string-in-source-relation lintian-fake-arch [build-depends: baz [source lintian-fake-arch]]
E: fields-build-depends-general source: invalid-arch-string-in-source-relation source [build-depends: baz [source lintian-fake-arch]]
diff --git a/t/tests/legacy-relations/desc b/t/tests/legacy-relations/desc
index 2e1cf5c..c341f56 100644
--- a/t/tests/legacy-relations/desc
+++ b/t/tests/legacy-relations/desc
@@ -16,7 +16,7 @@ Test-For:
conflicts-with-dependency
conflicts-with-version
depends-exclusively-on-makedev
- depends-on-build-essential-package-without-using-version
+ build-depends-on-build-essential-package-without-using-version
depends-on-essential-package-without-using-version
depends-on-obsolete-package
depends-on-old-emacs
diff --git a/t/tests/legacy-relations/tags b/t/tests/legacy-relations/tags
index b6dc7c9..f310183 100644
--- a/t/tests/legacy-relations/tags
+++ b/t/tests/legacy-relations/tags
@@ -1,10 +1,10 @@
E: relations source: build-conflicts-with-build-dependency bar [alpha test]
E: relations source: build-conflicts-with-build-dependency debmake [!powerpc]
E: relations source: build-depends-on-build-essential build-depends-indep
+E: relations source: build-depends-on-build-essential-package-without-using-version libc6-dev [build-depends: libc6-dev]
+E: relations source: build-depends-on-build-essential-package-without-using-version make [build-depends-indep: make]
E: relations source: build-depends-on-essential-package-without-using-version build-depends-indep: bash
E: relations source: build-depends-on-essential-package-without-using-version build-depends: findutils
-E: relations source: depends-on-build-essential-package-without-using-version libc6-dev [build-depends: libc6-dev]
-E: relations source: depends-on-build-essential-package-without-using-version make [build-depends-indep: make]
E: relations source: invalid-arch-string-in-source-relation test [build-conflicts: bar [alpha test]]
E: relations source: section-area-mismatch Package relations-multiple-libs
E: relations-multiple-libs: conflicts-with-dependency depends libpng2
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: