[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/01: Don't match, for example, "FB.login()" when used as a documentation example. (Closes: #884296)



This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 562d5e3f1b6a66ba698b533e94979960c96a7993
Author: Chris Lamb <lamby@debian.org>
Date:   Wed Dec 13 19:03:57 2017 +0000

    Don't match, for example, "FB.login()" when used as a documentation example. (Closes: #884296)
---
 data/files/privacy-breaker-fragments                                  | 2 +-
 debian/changelog                                                      | 4 ++++
 .../debian/src/privacy-breach-facebook/false-positives.html           | 2 ++
 3 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/data/files/privacy-breaker-fragments b/data/files/privacy-breaker-fragments
index 23c67bb..6412c19 100644
--- a/data/files/privacy-breaker-fragments
+++ b/data/files/privacy-breaker-fragments
@@ -23,7 +23,7 @@ plusone                    ~~ (?:<g:plusone|google\.com/js/plusone\.js\?onload=o
 flattr                     ~~ (?:api\.flattr\.com/js/\d(\.\d)?/load\.js|<a\s+class\s*=\s*"flattrbutton"|data-flattr-uid\s*=|flattrloader\.(?:setup\s*\(\)|render\s*\(|addloadevent\s*\()) ~~ privacy-breach-donation
 facebook                   ~~ (?:facebook-jssdk|xmlns:fb="https?://www.facebook.com/20\d\d/fbml)                                                 ~~ privacy-breach-facebook
 ogp.me/ns/fb               ~~ xmlns:fb="https?://ogp.me/ns/fb\#?"                                                                                      ~~ privacy-breach-facebook
-fb.                        ~~ fb\.(?:canvas|api|init|login|getloginstatus|event|ui|xfbml)                                                                  ~~ privacy-breach-facebook
+fb.                        ~~ fb\.(?:canvas|api|init|login|getloginstatus|event|ui|xfbml)(?!\()(?!<)                                                                  ~~ privacy-breach-facebook
 fb:                        ~~ </?fb:(?:activity|comments|friendpile|like|like-box|login-button|name|profile-pic|recommendations)\s+[^>]*>                  ~~ privacy-breach-facebook
 piwik                      ~~ (?:piwik_url\s*=|[\'"]piwik\.js[\'\"]|end\s+piwik\h+(?:tag|code)|[\'\"]settrackerurl[\'\"])                                  ~~ privacy-breach-piwik
 pkbaseurl                  ~~ pkbaseurl\s*=                                                                                                                ~~ privacy-breach-piwik
diff --git a/debian/changelog b/debian/changelog
index 5521862..7db8e01 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -41,6 +41,10 @@ lintian (2.5.63) UNRELEASED; urgency=medium
       in lintianrc.  (Closes: #813525)
     + [CL] Make -v imply --no-tag-display-limit.  (Closes: #812756)
 
+  * data/files/privacy-breaker-fragments:
+    + [CL] Don't match, for example, "FB.login()" when used as a
+      documentation example.  (Closes: #884296)
+
   * doc/lintianrc.example:
     + [CL] Add missing "jobs" entry.
 
diff --git a/t/tests/files-privacybreach/debian/src/privacy-breach-facebook/false-positives.html b/t/tests/files-privacybreach/debian/src/privacy-breach-facebook/false-positives.html
new file mode 100644
index 0000000..2673507
--- /dev/null
+++ b/t/tests/files-privacybreach/debian/src/privacy-breach-facebook/false-positives.html
@@ -0,0 +1,2 @@
+<pre>FB.login()</pre>
+<pre>FB.event</pre>

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: