Bug#876443: lintian: inconsequent about missing-build-dependency-for-dh_-command/useless-autoreconf-build-depends

[Rene Engelhard <rene@debian.org>]

Package: lintian
Version: 2.5.53
Severity: normal

I get

E missing-build-dependency-for-dh_-command
dh_strip_nondeterminism => dh-strip-nondeterminism

for libreoffice on lintian.d.o (and afaicr also with some lintian when
ran on the actual source package built).

the explanation says:

The source package appears to be using a dh_ command but doesn't build depend on the package that actually provides it. If it uses it, it must build depend on it.

Severity: important, Certainty: possible

Check: debhelper, Type: source

Ok, so let's do that.

https://anonscm.debian.org/cgit/pkg-openoffice/libreoffice.git/commit/?h=debian-experimental-5.4&id=ce92602c49fa5f5b4e604e890e08589f94f11b7b

As the comment says, this one is already pretty inconsequent since dh-autoreconf
is not complained about but debhelper depends on both itself.

After that change I now get:

W: libreoffice source: useless-autoreconf-build-depends dh-autoreconf
N: 
N:    Since compatibility level 10, debhelper enables the autoreconf sequence
N:    by default.
N:    
N:    It is therefore not necessary to specify build-dependencies on
N:    dh-autoreconf or autotools-dev and they can be removed.
N:    
N:    Severity: normal, Certainty: possible
N:    
N:    Check: debhelper, Type: source
N: 

but as said, both dh-autoreconf *AND* dh-strip-nondeterminism are dependencies
of debhelper already. (ok, only from stable onwards, but..)

Either lintian should error out/warn about both or for none of them.

Regards,

Rene