Bug#873702: lintian: False positive: desktop-entry-lacks-keywords-entry

[Коля Гурьев <guriev-ns@ya.ru>]

Hi, thank you for the fix!

> diff --git a/checks/menu-format.pm b/checks/menu-format.pm
> index 3de4490..be1a1c4 100644
> --- a/checks/menu-format.pm
> +++ b/checks/menu-format.pm
> @@ -641,7 +641,7 @@ sub verify_desktop_file {
>          if (!defined $vals{Icon}) {
>              tag 'desktop-entry-lacks-icon-entry', $file;
>          }
> -        if (!defined $vals{Keywords}) {
> +        if (!defined $vals{Keywords} && $vals{'Type'} ne 'Link') {
>              tag 'desktop-entry-lacks-keywords-entry', $file;
>          }
>      }

But if I understand the specification properly, the Keywords field is 
forbidden not only for links (type 2 in the specification) but also for 
directories (type 3). In general, this field is allowed for applications 
(type 1). I therefore think the correct condition would be like the next.

    if (!defined $vals{Keywords} && $vals{'Type'} eq 'Application') {
        ...
    }

(I'm not familiar with Perl, and I don't know how it should look).