[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/01: Prevent a false positive of missing-build-dependency-for-dh_-command that can be exposed by following the advice for the recently added useless-autoreconf-build-depends tag. (Closes: #869541)



This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit d78d475e6cdf000fcb879dc3a2788773c7536917
Author: Chris Lamb <lamby@debian.org>
Date:   Mon Jul 24 22:41:42 2017 +0100

    Prevent a false positive of missing-build-dependency-for-dh_-command that can be exposed by following the advice for the recently added useless-autoreconf-build-depends tag. (Closes: #869541)
---
 checks/debhelper.pm                                       |  1 +
 debian/changelog                                          |  5 +++++
 .../debian/debian/compat                                  |  1 +
 .../debian/debian/control.in                              | 15 +++++++++++++++
 .../debian/debian/rules                                   |  8 ++++++++
 t/tests/debhelper-autoreconf-build-depends-unrel/desc     |  7 +++++++
 t/tests/debhelper-autoreconf-build-depends-unrel/tags     |  0
 7 files changed, 37 insertions(+)

diff --git a/checks/debhelper.pm b/checks/debhelper.pm
index a0aa3d0..6ef0a1b 100644
--- a/checks/debhelper.pm
+++ b/checks/debhelper.pm
@@ -433,6 +433,7 @@ sub run {
 
     while (my ($dep, $command) = each %missingbdeps) {
         next if $dep eq 'debhelper'; #handled above
+        next if $dep eq 'autotools-dev' and $level >= 10;
         tag 'missing-build-dependency-for-dh_-command', "$command => $dep"
           unless ($bdepends_noarch->implies($dep));
     }
diff --git a/debian/changelog b/debian/changelog
index 94784cc..21efac3 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,11 @@ lintian (2.5.53) UNRELEASED; urgency=medium
 
   XXX: generate tag summary
 
+  * checks/debhelper.pm:
+    + [CL] Prevent a false positive of
+      missing-build-dependency-for-dh_-command that can be exposed by
+      following the advice for the recently added
+      useless-autoreconf-build-depends tag.  (Closes: #869541)
   * checks/scripts.pm:
     + [CL] Correct false positives in
       unconditional-use-of-dpkg-statoverride by detecting "if !" as a
diff --git a/t/tests/debhelper-autoreconf-build-depends-unrel/debian/debian/compat b/t/tests/debhelper-autoreconf-build-depends-unrel/debian/debian/compat
new file mode 100644
index 0000000..f599e28
--- /dev/null
+++ b/t/tests/debhelper-autoreconf-build-depends-unrel/debian/debian/compat
@@ -0,0 +1 @@
+10
diff --git a/t/tests/debhelper-autoreconf-build-depends-unrel/debian/debian/control.in b/t/tests/debhelper-autoreconf-build-depends-unrel/debian/debian/control.in
new file mode 100644
index 0000000..a64ef50
--- /dev/null
+++ b/t/tests/debhelper-autoreconf-build-depends-unrel/debian/debian/control.in
@@ -0,0 +1,15 @@
+Source: {$source}
+Priority: extra
+Section: {$section}
+Maintainer: {$author}
+Standards-Version: {$standards_version}
+Build-Depends: {$build_depends}, debhelper (>= 10)
+
+Package: {$source}
+Architecture: {$architecture}
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
+Description: {$description}
+ This is a test package designed to exercise some feature or tag of
+ Lintian.  It is part of the Lintian test suite and may do very odd
+ things.  It should not be installed like a regular package.  It may
+ be an empty package.
diff --git a/t/tests/debhelper-autoreconf-build-depends-unrel/debian/debian/rules b/t/tests/debhelper-autoreconf-build-depends-unrel/debian/debian/rules
new file mode 100755
index 0000000..005519a
--- /dev/null
+++ b/t/tests/debhelper-autoreconf-build-depends-unrel/debian/debian/rules
@@ -0,0 +1,8 @@
+#!/usr/bin/make -f
+
+%:
+	dh $@
+
+override_dh_auto_configure:
+	dh_auto_configure
+	dh_autotools-dev_updateconfig
diff --git a/t/tests/debhelper-autoreconf-build-depends-unrel/desc b/t/tests/debhelper-autoreconf-build-depends-unrel/desc
new file mode 100644
index 0000000..c243270
--- /dev/null
+++ b/t/tests/debhelper-autoreconf-build-depends-unrel/desc
@@ -0,0 +1,7 @@
+Testname: debhelper-autoreconf-build-depends-unrel
+Version: 1.0
+Description: Test for useless autoreconf-related build dependencies false positives
+Test-Depends: debhelper (>= 10)
+Test-Against:
+ missing-build-dependency-for-dh_-command
+ useless-autoreconf-build-depends
diff --git a/t/tests/debhelper-autoreconf-build-depends-unrel/tags b/t/tests/debhelper-autoreconf-build-depends-unrel/tags
new file mode 100644
index 0000000..e69de29

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: