Bug#869541: lintian warns both with and without autotools-dev build-dep

[Niels Thykier <niels@thykier.net>]

Brendan O'Dea:
> Package: lintian
> Version: 2.5.52
> 
> I added calls to dh_autotools-dev_{update,restore}config to the debian/rules
> for vile* in order to update/restore the config.guess/config.sub.  I added a
> versioned build-dependency for the version of autotools-dev which added these
> commands:
> 
>   autotools-dev (>= 20100122.1)
> 
> lintian issued the folowing warning:
> 
>   W: vile source: useless-autoreconf-build-depends autotools-dev
> 
> If I remove the dependency, lintian then gives the error:
> 
>   E: vile source: missing-build-dependency-for-dh_-command dh_autotools-dev_restoreconfig => autotools-dev
> 
> * https://anonscm.debian.org/gitweb/?p=collab-maint/vile.git
> 

True, that is a bit unfortunate.  I suspect the former tag implicit
assumes that you use "dh" and not classic debhelper.

A quick fix for the vile package could be to replace the
dh_autotools-dev_updateconfig command with dh_update_autotools_config
and then drop dh_autotools-dev_restoreconfig.  That would give you the
same features without the autotools-dev B-D (plus one command less in
your d/rules).

Thanks,
~Niels