Bug#868178: marked as done (lintian: enable r-data-without-readme-source check also for .RData files)
Your message dated Sun, 23 Jul 2017 10:45:50 +0000
with message-id <E1dZEOU-000FGH-9V@fasolo.debian.org>
and subject line Bug#868178: fixed in lintian 2.5.52
has caused the Debian Bug report #868178,
regarding lintian: enable r-data-without-readme-source check also for .RData files
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)
--
868178: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=868178
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: lintian
Severity: wishlist
Tags: patch
Hi,
Please find attached a patch that enable r-data-without-readme-source
check also for .RData files (with a upper-case D that is found in some
R packages [1]).
The patch also add reference about the decision from the FTP team.
Best regards,
Dylan
[1] https://codesearch.debian.net/search?q=%5C.RData
From 49f8d0b28710ace446cb99433d5da19292eba0e6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dylan=20A=C3=AFssi?= <bob.dybian@gmail.com>
Date: Wed, 12 Jul 2017 21:27:57 +0200
Subject: [PATCH] Enable r-data-without-readme-source check also for .RData
files
---
checks/cruft.desc | 1 +
checks/cruft.pm | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/checks/cruft.desc b/checks/cruft.desc
index d0e1497..93ae0c5 100644
--- a/checks/cruft.desc
+++ b/checks/cruft.desc
@@ -878,6 +878,7 @@ Info: Many modules packaged for the R Project for Statistical Computing contain
debian/README.source, which this package is missing.
.
Please add a README.source documenting the origins of these files.
+Ref: https://lists.debian.org/debian-devel/2013/09/msg00332.html
Tag: file-contains-fixme-placeholder
Severity: important
diff --git a/checks/cruft.pm b/checks/cruft.pm
index 5ed8b53..05d8901 100644
--- a/checks/cruft.pm
+++ b/checks/cruft.pm
@@ -652,7 +652,7 @@ sub find_cruft {
}
# Ensure we have a README.source for R data files
- if ( $basename =~ m,\.(?:rda|Rda|rdata|Rdata)$,
+ if ( $basename =~ m,\.(?:rda|Rda|rdata|Rdata|RData)$,
&& $entry->is_file
&& !$info->index_resolved_path('debian/README.source')) {
tag 'r-data-without-readme-source', $name;
--
2.1.4
--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 2.5.52
We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 868178@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Niels Thykier <niels@thykier.net> (supplier of updated lintian package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 23 Jul 2017 07:18:06 +0000
Source: lintian
Binary: lintian
Architecture: source
Version: 2.5.52
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Niels Thykier <niels@thykier.net>
Description:
lintian - Debian package checker
Closes: 605999 652963 764486 792846 802721 807461 825348 827941 828720 833585 833691 841670 841832 843428 844191 846009 856137 860801 865055 865882 866322 867042 867673 868178
Changes:
lintian (2.5.52) unstable; urgency=medium
.
* Summary of tag changes:
+ Added:
- appstream-metadata-in-legacy-location
- appstream-metadata-legacy-format
- appstream-metadata-malformed-modalias-provide
- appstream-metadata-missing-modalias-provide
- copyright-contains-automatically-extracted-boilerplate
- copyright-year-in-future
- debian-rules-sets-DEB_BUILD_OPTIONS
- elf-maintainer-script
- emacsen-common-without-dh-elpa
- file-contains-fixme-placeholder
- gobject-instrospection-package-missing-depends-on-gir-depends
- manpage-has-overly-generic-name
- orig-tarball-missing-upstream-signature
- package-installs-deprecated-upstart-configuration
- udev-rule-missing-subsystem
- udev-rule-missing-uaccess
- udev-rule-unreadable
- unconditional-use-of-dpkg-statoverride
- useless-autoreconf-build-depends
+ Removed:
- copyright-contains-dh-make-perl-boilerplate
- package-depends-on-multiple-tkx-versions
- restriction-formula-with-debhelper-without-debhelper-version
- restriction-formula-without-versioned-dpkg-dev-dependency
.
* checks/appstream-metadata.{desc,pm}:
+ [NT] New check by Petter Reinholdtsen.
* checks/changelog-file.desc:
+ [AB] Fix typo "%gt;" vs ">".
+ [CL] Expand the rationale for the
latest-debian-changelog-entry-without-new-date tag to mention
possible implications for SOURCE_DATE_EPOCH/reproducible builds.
* checks/control-file.pm:
+ [NT] Remove check for missing versioned build-depends for dpkg
and debhlper when using Build-Profiles. The necessary versions
are now in oldstable.
+ [CL] Add check for GObject Introspection packages that are missing
binary dependencies on ${gir:Depends}. (Closes: #860801)
* checks/changes-file.{desc,pm}:
+ [CL] Check for the presence of an .asc signature if an upstream
signing key is present. (Closes: #833585)
* checks/copyright-file.{desc,pm}:
+ [CL] Rename copyright-contains-dh-make-perl-boilerplate to
copyright-contains-automatically-extracted-boilerplate as it can
be generated by other tools such as dh-make-elpa. Thanks to Sean
Whitton for the report. (Closes: #841832)
+ [CL] Check for years that are later than the last entry added to
debian/changelog. (Closes: #807461)
* checks/cruft.{desc,pm}:
+ [CL] Clarify language of source-contains-prebuilt-ms-help-file
description; there exists free software to generate .chm files.
+ [CL] Don't emit source-contains-prebuilt-ms-help-file for files
generated by Halibut. (Closes: #867673)
+ [CL] Move r-data-without-readme-source to check the source package,
no the binary; the expected README.source files are not installed
in binary packages. (Closes: #866322)
+ [CL] Apply patch from Dylan Aïssi to also check for .RData files
(not just .Rdata) files in r-data-without-readme-source.
(Closes: #868178)
+ [CL] Check for "FIXME" and similar placeholders in various files
under debian/. (Closes: #846009)
* checks/debhelper.{desc,pm}:
+ [CL] Check for useless build-dependencies on dh-autoreconf or
autotools-dev under compat levels 10 or higher. (Closes: #844191)
* checks/elpa.{desc,pm}:
+ [NT] Apply patch from Sean Whitton to add elpa related checks.
(Closes: #867042)
* checks/fields.{desc,pm}:
+ [NT] Remove check for missing versioned build-depends for dpkg
and debhlper when using Build-Profiles. The necessary versions
are now in oldstable.
+ [NT] Drop check for depending on multiple versions of tkx as
tkx does not seem to be in Debian any longer.
* checks/files.pm:
+ [CL] Add .yml to the list of file extensions to avoid false
positives when emitting extra-license-file, with testcase. Thanks
to Rene Engelhard for the report. (Closes: #856137)
+ [CL] Check for packages containing upstart configuration under
/etc/init. Thanks to Paul Wise for the report. (Closes: #825348)
* checks/init.d.desc:
+ [CL] Add an example snippet to explain how to prevent emission
of init.d-script-sourcing-without-test.
* checks/manpages.{desc,pm}:
+ [CL] Check for overly-generic filenames such as README.3pm.gz.
(Closes: #792846)
* checks/menu-format.desc:
+ [ADB] Fix formatting of desktop-entry-lacks-icon-entry
* checks/scripts.desc:
+ [CL] Upgrade new-package-should-not-package-python2-module from
I: to W:. See #829744 for more info.
+ [CL] Clarify wording in new-package-should-not-package-python2-module
to make the justification clearer.
+ [CL] Check for calls to dpkg-statoverride --add without a
corresponding --list. (Closes: #652963)
+ [CL] Add missing "contains" verb to the description of the
debhelper-autoscript-in-maintainer-scripts tag.
+ [CL] Emit new "elf-maintainer-script" classification tag if
debian/postinst (etc.) is an ELF binary.
* checks/rules.desc:
+ [CL] Clarify wording in debian-rules-parses-dpkg-parsechangelog to
make the justification clearer. (Closes: #865882)
+ [CL] Check for files setting DEB_BUILD_OPTIONS instead of
DH_BUILD_MAINT_OPTIONS. (Closes: #833691)
* checks/udev.{desc,pm}:
+ [NT] New check by Petter Reinholdtsen.
* checks/watch-file.pm:
+ [CL] Factor out hard-coded list of possible upstream key locations
to the "common/signing-key-filenames" Lintian::Data resource.
.
* collection/scripts:
+ [CL] Check that non-ELF maintainer scripts start with #!.
(Closes: #843428)
.
* commands/lintian.pm:
+ [NT] Attempt to clean up on SIGTERM (like with SIGINT).
+ [CL] Allow the use of suppress-tags=<tag>[,<tag>[,<tag>]] in
lintianrc. (Closes: #764486)
* commands/reporting-html-reports:
+ [NT] Enable re-use of the memory for the maintainer mapping once the
log file as been parsed.
+ [CL] Consistently use the same "Debian style" RFC 822 date format for
both "Mirror timestamp" and "Last updated" on the index page.
(Closes: #828720)
* commands/reporting-sync-state:
+ [NT] Re-encode checksums into base64 encoded strings (from hex).
This reduces size per checksum by about ~30% (disk and memory). This
reduction is also applicable to other reporting tools that loads the
harness cache.
.
* data/cruft/non-free-files:
+ [CL] Match more Lena Söderberg images. Thanks to Lumin
<cdluminate@gmail.com> and Dylan Aïssi <bob.dybian@gmail.com>.
(Closes: #827941)
* data/fields/build-profiles:
+ [NT] Add patch from Mattia Rizzolo to update the list of known build
profiles, adding «nolua» and «noruby».
* data/spelling/corrections:
+ [AB] Remove "iff". It's a valid English word. (Closes: #865055)
.
* debian/control:
+ [NT] Add (Build-)Depends on libxml-simple-perl for the new
appstream-metadata check.
+ [NT] Apply patch from Sean Whitton to add a Build-Depends on dh-elpa
for a test.
+ [NT] Prefer default-jdk-headless to default-jdk when available.
* debian/rules:
+ [JW, NT] Post process HTML docmentation to set the charset to UTF-8,
which fixes mojibake in the Debian Policy Manual links. Thanks to
Paul Hardy for finding a solution to the problem.
(Closes: #802721)
+ [NT] Override dh_autoreconf tools as they are not used (but need to
scan over all files in the source package).
.
* lib/Lintian/Collect/Source.pm:
+ [CL] Improve support for "3.0 (git)" packages. They are still marked
as unsupported-source-format as they are not accepted by the Debian
archive. (Closes: #605999)
* lib/Lintian/Util.pm:
+ [NT] Fix uninitialized warning if a fork call fails.
.
* profiles/debian/main.profile:
+ [NT] Enable appstream-metadata + udev check by default.
(Closes: #841670)
.
* t/tests/spelling-general/debian/debian/copyright:
+ [CL] Add regression test for #844166.
Checksums-Sha1:
1693d5159507a47c6e3c0102ff30540783fdfe28 2866 lintian_2.5.52.dsc
8419e0d64136bfc1e0361e9acd6690a7c13770c4 1233360 lintian_2.5.52.tar.xz
484861d0acfb026ec8d5575255ce789c48b391a7 16199 lintian_2.5.52_source.buildinfo
Checksums-Sha256:
d35410165d38b33b6cdacb0287b5249c73f951a6669739860f6e1032467084e5 2866 lintian_2.5.52.dsc
c65c0b0fb4b4d0bb423555ae5abab62aad09aea6c37de46a4ed15d1ad67a3af2 1233360 lintian_2.5.52.tar.xz
45c7f60918803f1a665b27478050508d94ed5104b0a9c618f4ac5dda70632fe0 16199 lintian_2.5.52_source.buildinfo
Files:
1c5cd625a286181c7a80f27e7b7f525c 2866 devel optional lintian_2.5.52.dsc
aa745caffb7f20854b0b08a0a5280b4c 1233360 devel optional lintian_2.5.52.tar.xz
6dda94054d6f62ee3334b43a827e109a 16199 devel optional lintian_2.5.52_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEsxMaRR2/33ygW0GXBUu7n32AZEIFAll0TsgACgkQBUu7n32A
ZEKUxg//Rdgrzd5bzqkCYT/NizhyiSQv8wOfjLaKhHzhpnjuLYxJQthuQOtbcrHs
neu6vk5xFwFvubG/7ulhD1UPGJFTVGh5XNEPajSkzFFl0n85J57e0850AiGy3rkz
LyePrRjCXY1s0X8s8/KLjp+sMVgiGY5kKFA0W+Ak1NNHpls+ZD86nirOz+3qX0yG
cMAc5rDnXAzJv1jsbF6LQPotp743weofxc+Sj7Uywh2lJ8n5Rdvp8/GqSD8oq+rW
6lr2OXI9M5AD//0xpTsp6wMDZYXCIoAcPeHzDep3FppJxCPa1bv3oewr7/AR0DBr
I980ai87D7/nSjKfKr7swvfLnOy7hLKdsH8nZfbn/Q0i6Lr531sFgtYWRr1jftPU
qVj5EF5ATMu0vPPGdl6uP8mwIy/ojeKwtks+4B9APzx3nkQR94GTla8ZtreWZJcm
o6LNT0UZka+J0rcHyCp9huvlQc1wDIYEZgT2/D/Ljv6LLaLp6ENc4q895stmoTrI
+pMo5HocJChGPtuL+Q4lOZ9ROufjvoNreaXhhICawcZKjjxQ9vJ3cx5BGQT/SweY
dOp5Q7/Ykzm8IBzN4yyDxo86StiXf3KF61wiUJCNT+xINdLOv1scdiSntVzMhMdD
3R5lKdxHXNwxs2wqBOIzwuBjK6MtnN2CTw21qMJ5D3O/+K+oci8=
=xKEt
-----END PGP SIGNATURE-----
--- End Message ---
Reply to: