[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#839822: [PATCH] Allow debhelper "--with" addons to be quoted



Subject: Allow debhelper "--with" addons to be quoted
Package: lintian
Version: 2.5.48
Severity: wishlist
Tags: patch

Hi,

Here is a patch which allows quoting debhelper addons names in rules
files, for example:

dh $@ --with 'python2'

Regards

Yann
diff --git a/checks/debhelper.pm b/checks/debhelper.pm
index 62c6372..1dd99d5 100644
--- a/checks/debhelper.pm
+++ b/checks/debhelper.pm
@@ -134,8 +134,8 @@ sub run {
             $seencommand = 1;
             $needbuilddepends = 1;
             $needtomodifyscripts = 1;
-            while (m/\s--with(?:=|\s+)(\S+)/go) {
-                my $addon_list = $1;
+            while (m/\s--with(?:=|\s+)(['"]?)(\S+)\1/go) {
+                my $addon_list = $2;
                 for my $addon (split(m/,/o, $addon_list)) {
                     $addon =~ y,-,_,;
                     my $depends =$dh_addons_manual->value($addon)

Reply to: