[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#834370: lintian: c/debhelper.pm: Correct false positive in matching targets with extra whitespace



Niels Thykier:
> Chris Lamb:
>> [...]
> 
> Hi,
> 
> Thanks for working on this. :)
> 
> This makes me wonder if:
> 
>   # Skip these
>   override_dh_foo override_dh_bar:
> 
> work as intended[1]. From a quick glance, it looks like our code only
> validates the first override in a single line.
> 
> Thanks,
> ~Niels
> 
> [1] Examples include:
> https://anonscm.debian.org/git/debhelper/debhelper.git/tree/debian/rules
> 

Obviously, I would forget to mention that we also have:

 override_dh_foo-arch (or override_dh_foo-indep)

Which preferably should be matched against dh_foo rather than
dh_foo-{arch,indep}.

(Admittedly, this would generally go in the false-negative bucket, but
while we are fixing this check, we might as well support it).

Thanks,
~Niels


Reply to: