Bug#802028: Line length is not a good indicator for javascript files being not in preferred way of modification
Package: lintian
Version: 2.5.38
Severity: important
Hi! While packaging Qt5 I had quite a lot of false positives because lintian
considers javascript with long lines as a prebuilt one.
As an example, in qtwebkit-opensource-src's
Source/WebInspectorUI/UserInterface/ActivateButtonNavigationItem.js::272
WebInspector.ActivateButtonNavigationItem.prototype.__proto__ = WebInspector.ButtonNavigationItem.prototype;
It's a pretty valid line.
I'm getting two errors, possibly related: source-contains-prebuilt-javascript-object and
source-is-missing. Both of them are false.
The complete list in the above mentioned src package would be:
P: qtwebkit-opensource-src source: source-contains-prebuilt-javascript-object Source/WebInspectorUI/UserInterface/ActivateButtonNavigationItem.js line length is 272 characters (>256)
E: qtwebkit-opensource-src source: source-is-missing Source/WebInspectorUI/UserInterface/ActivateButtonNavigationItem.js
P: qtwebkit-opensource-src source: source-contains-prebuilt-javascript-object Source/WebInspectorUI/UserInterface/ConsoleMessageImpl.js line length is 260 characters (>256)
E: qtwebkit-opensource-src source: source-is-missing Source/WebInspectorUI/UserInterface/ConsoleMessageImpl.js
P: qtwebkit-opensource-src source: source-contains-prebuilt-javascript-object Source/WebInspectorUI/UserInterface/DOMTree.js line length is 283 characters (>256)
E: qtwebkit-opensource-src source: source-is-missing Source/WebInspectorUI/UserInterface/DOMTree.js
P: qtwebkit-opensource-src source: source-contains-prebuilt-javascript-object Source/WebInspectorUI/UserInterface/DebuggerSidebarPanel.js line length is 266 characters (>256)
E: qtwebkit-opensource-src source: source-is-missing Source/WebInspectorUI/UserInterface/DebuggerSidebarPanel.js
P: qtwebkit-opensource-src source: source-contains-prebuilt-javascript-object Source/WebInspectorUI/UserInterface/InspectorBackendCommands.js line length is 362 characters (>256)
E: qtwebkit-opensource-src source: source-is-missing Source/WebInspectorUI/UserInterface/InspectorBackendCommands.js
P: qtwebkit-opensource-src source: source-contains-prebuilt-javascript-object Source/WebInspectorUI/UserInterface/LogContentView.js line length is 325 characters (>256)
E: qtwebkit-opensource-src source: source-is-missing Source/WebInspectorUI/UserInterface/LogContentView.js
P: qtwebkit-opensource-src source: source-contains-prebuilt-javascript-object Source/WebInspectorUI/UserInterface/ProfileView.js line length is 284 characters (>256)
E: qtwebkit-opensource-src source: source-is-missing Source/WebInspectorUI/UserInterface/ProfileView.js
P: qtwebkit-opensource-src source: source-contains-prebuilt-javascript-object Source/WebInspectorUI/UserInterface/ResourceSidebarPanel.js line length is 520 characters (>256)
E: qtwebkit-opensource-src source: source-is-missing Source/WebInspectorUI/UserInterface/ResourceSidebarPanel.js
All of them false positives.
So I think this is not a good measurement tool :-/
Kinds regards, Lisandro.
-- System Information:
Debian Release: stretch/sid
APT prefers unstable
APT policy: (990, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.2.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=es_AR.UTF-8, LC_CTYPE=es_AR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)
Versions of packages lintian depends on:
ii binutils 2.25.1-6
ii bzip2 1.0.6-8
ii diffstat 1.60-1
ii file 1:5.25-2
ii gettext 0.19.6-1
ii hardening-includes 2.7
ii intltool-debian 0.35.0+20060710.4
ii libapt-pkg-perl 0.1.29+b3
ii libarchive-zip-perl 1.53-1
ii libclass-accessor-perl 0.34-1
ii libclone-perl 0.38-1
ii libdpkg-perl 1.18.3
ii libemail-valid-perl 1.196-1
ii libfile-basedir-perl 0.07-1
ii libipc-run-perl 0.94-1
ii liblist-moreutils-perl 0.413-1
ii libparse-debianchangelog-perl 1.2.0-8
ii libtext-levenshtein-perl 0.13-1
ii libtimedate-perl 2.3000-2
ii liburi-perl 1.69-1
ii man-db 2.7.4-1
ii patchutils 0.3.4-1
ii perl [libdigest-sha-perl] 5.20.2-6
ii t1utils 1.38-4
ii xz-utils 5.1.1alpha+20120614-2.1
Versions of packages lintian recommends:
ii dpkg 1.18.3
pn libperlio-gzip-perl <none>
ii perl 5.20.2-6
ii perl-modules [libautodie-perl] 5.20.2-6
Versions of packages lintian suggests:
pn binutils-multiarch <none>
ii dpkg-dev 1.18.3
ii libhtml-parser-perl 3.71-2
ii libtext-template-perl 1.46-1
ii libyaml-perl 1.13-1
-- no debconf information
Reply to: