[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#718820: [lintian] Please rename font-adobe-copyrighted-fragment-(:?no-credit)



Package: lintian
Version: 2.5.14
Severity: normal
control: tag -1 + patch

Please rename 
s/font-adobe-copyrighted-fragment/licence-problem-font-adobe-copyrighted-fragment/g
s/font-adobe-copyrighted-fragment-no-credit/licence-problem-font-adobe-copyrighted-fragment-no-credit/g

Override for the second one are bogus (I have manually verefied and open a bug report).
From cb7baadd61b46ba9dd094bea48e2633db1066d4a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bastien=20ROUCARI=C3=88S?= <roucaries.bastien@gmail.com>
Date: Mon, 5 Aug 2013 22:57:24 +0200
Subject: [PATCH] Rename license problem tag to license-problem prefix

In order to be consistant rename
* font-adobe-copyrighted-fragment to license-problem-font-adobe-copyrighted-fragment
* font-adobe-copyrighted-fragment-no-credit to license-problem-font-adobe-copyrighted-fragment-no-credit
---
 checks/files.desc             |    4 ++--
 checks/files.pm               |    4 ++--
 t/tests/files-adobe-font/desc |    4 ++--
 t/tests/files-adobe-font/tags |    6 +++---
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/checks/files.desc b/checks/files.desc
index 5c22059..55f94fd 100644
--- a/checks/files.desc
+++ b/checks/files.desc
@@ -959,7 +959,7 @@ Info: This package contains a *.ttf, *.otf, or *.pfb file, file
  the font should be packaged separately, since fonts are usually useful
  outside of the package that embeds them.
 
-Tag: font-adobe-copyrighted-fragment
+Tag: license-problem-font-adobe-copyrighted-fragment
 Severity: serious
 Certainty: possible
 Info: This type 1 font file includes some postscript fragment with a
@@ -969,7 +969,7 @@ Info: This type 1 font file includes some postscript fragment with a
  Should this be a false-positive, please override the tag.
 Ref: http://wiki.debian.org/qa.debian.org/type1nondfsg
 
-Tag: font-adobe-copyrighted-fragment-no-credit
+Tag: license-problem-font-adobe-copyrighted-fragment-no-credit
 Severity: serious
 Certainty: possible
 Info: This type 1 font file includes some postscript fragment with a
diff --git a/checks/files.pm b/checks/files.pm
index c5ec884..a080e56 100644
--- a/checks/files.pm
+++ b/checks/files.pm
@@ -1022,7 +1022,7 @@ foreach my $file ($info->sorted_index) {
                while (my $line = <$t1pipe>) {
                     if ($foundadobeline) {
                        if ($line =~ m/^[%\s]*All\s*Rights\s*Reserved\.?\s*$/i) {
-                          tag 'font-adobe-copyrighted-fragment', $file;
+                          tag 'license-problem-font-adobe-copyrighted-fragment', $file;
                           last;
                        } else {
                           $foundadobeline = 0;
@@ -1035,7 +1035,7 @@ foreach my $file ($info->sorted_index) {
                     # the only place where the startlock is documented is in the black book
                     # copyrighted fragment
                     if ($line =~ m/startlock\s*get\s*exec/) {
-                        tag 'font-adobe-copyrighted-fragment-no-credit', $file;
+                        tag 'license-problem-font-adobe-copyrighted-fragment-no-credit', $file;
                         last;
                     }
                }
diff --git a/t/tests/files-adobe-font/desc b/t/tests/files-adobe-font/desc
index 08f339b..a6cd634 100644
--- a/t/tests/files-adobe-font/desc
+++ b/t/tests/files-adobe-font/desc
@@ -3,5 +3,5 @@ Sequence: 6000
 Version: 1.0
 Description: Test for adobe font license issues
 Test-For:
- font-adobe-copyrighted-fragment
- font-adobe-copyrighted-fragment-no-credit
+ license-problem-font-adobe-copyrighted-fragment
+ license-problem-font-adobe-copyrighted-fragment-no-credit
diff --git a/t/tests/files-adobe-font/tags b/t/tests/files-adobe-font/tags
index ded07f3..1853b47 100644
--- a/t/tests/files-adobe-font/tags
+++ b/t/tests/files-adobe-font/tags
@@ -1,3 +1,3 @@
-E: fonts-files-adobe-font: font-adobe-copyrighted-fragment usr/share/lintian/fonts/bad.pfb
-E: fonts-files-adobe-font: font-adobe-copyrighted-fragment usr/share/lintian/fonts/badwithadobecode.pfb
-E: fonts-files-adobe-font: font-adobe-copyrighted-fragment-no-credit usr/share/lintian/fonts/badnocredit.pfb
+E: fonts-files-adobe-font: license-problem-font-adobe-copyrighted-fragment usr/share/lintian/fonts/bad.pfb
+E: fonts-files-adobe-font: license-problem-font-adobe-copyrighted-fragment usr/share/lintian/fonts/badwithadobecode.pfb
+E: fonts-files-adobe-font: license-problem-font-adobe-copyrighted-fragment-no-credit usr/share/lintian/fonts/badnocredit.pfb
-- 
1.7.10.4


Reply to: