Bug#712394: Warn if override_dh_auto_test target doesn't check for DEB_BUILD_OPTIONS=nocheck

[Daniel Schepler <dschepler@gmail.com>]

Package: lintian
Version: 2.5.13
Severity: wishlist

In my porting work, I've frequently seen cases where a debian/rules file 
provides an override_dh_auto_test target, but that target doesn't check for 
DEB_BUILD_OPTIONS containing nocheck before running the tests.  According to 
#568897 it's a deliberate design choice that override_dh_auto_test needs to 
replicate this check which is internally done in the default dh_auto_test 
command, in order to allow for cases where *not* running the testsuite would 
cause an FTBFS.  But in most cases I've seen it looks like it's just an 
oversight, or maintainers assuming dh will check for "nocheck" before calling 
override_dh_auto_test.

So, it would be nice to have lintian issue a warning if an 
override_dh_auto_test target doesn't contain any mention of DEB_BUILD_OPTIONS 
or nocheck.  I don't know what would be the best way to implement such a 
check, though.  Maybe it could trigger if debian/rules contains 
override_dh_auto_test anywhere, but doesn't have any line matching 
(nocheck.*DEB_BUILD_OPTIONS|DEB_BUILD_OPTIONS.*nocheck).
-- 
Daniel Schepler