[SCM] Debian package checker branch, master, updated. 2.5.10-186-gf54526d
The following commit has been merged in the master branch:
commit f54526d276c68b511c6ff9e72e1c3b8c7b7903e2
Author: Niels Thykier <niels@thykier.net>
Date: Tue Oct 2 21:07:28 2012 +0200
c/shared-libs: Check for use of ">" and "<" in shlibs file
Signed-off-by: Niels Thykier <niels@thykier.net>
diff --git a/checks/shared-libs b/checks/shared-libs
index f108a03..dee5a7e 100644
--- a/checks/shared-libs
+++ b/checks/shared-libs
@@ -359,6 +359,8 @@ if ($#shlibs == -1) {
unless ($provides->implies($depend)) {
tag 'shlibs-declares-dependency-on-other-package', $depend;
}
+ tag 'shlibs-uses-obsolete-relation', $depend
+ if $depend =~ m/\(\s*[><](?![<>=])\s*/;
}
}
}
diff --git a/checks/shared-libs.desc b/checks/shared-libs.desc
index 4a82e3e..a3f5b21 100644
--- a/checks/shared-libs.desc
+++ b/checks/shared-libs.desc
@@ -446,3 +446,12 @@ Certainty: certain
Ref: https://wiki.ubuntu.com/MultiarchSpec
Info: The package is marked as Multi-Arch: foreign, but it includes a shared
library in a public library directory.
+
+Tag: shlibs-uses-obsolete-relation
+Ref: policy 7.1
+Severity: normal
+Certainty: certain
+Info: The forms "<" and ">" mean "<=" and ">=", not "<<"
+ and ">>" as one might expect. For that reason these forms are
+ obsolete, and should not be used in new packages. Use the longer forms
+ instead.
diff --git a/debian/changelog b/debian/changelog
index 0c8cfab..86418e9 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,7 @@ lintian (2.5.11) UNRELEASED; urgency=low
+ Added:
- dm-upload-allowed-is-obsolete
- field-name-typo-in-dep5-copyright
+ - shlibs-uses-obsolete-relation
- untranslatable-debconf-templates
+ Removed:
- apparently-truncated-elf-binary
@@ -93,6 +94,8 @@ lintian (2.5.11) UNRELEASED; urgency=low
to mention that the dev symlink is always expected in /usr.
+ [NT] Add missing "+" in libtool regex. Thanks to Leo 'costela'
Antunes for the report.
+ + [RA,NT] Check for use of obsolete "<" and ">" in shlibs control
+ files. (Closes: #660655)
* checks/scripts{,.desc}:
+ [NT] Retire check for dpkg-maintscript-helper in preinst.
(Closes: #685497)
diff --git a/t/COVERAGE b/t/COVERAGE
index f08e527..259890b 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -1,5 +1,5 @@
-Last generated 2012-10-01
-Coverage (Tags): 879/963 (91.28%), w. legacy tests: 946/963 (98.23%)
+Last generated 2012-10-02
+Coverage (Tags): 880/964 (91.29%), w. legacy tests: 947/964 (98.24%)
Coverage (Checks): 33/41 (80.49%), w. legacy tests: 36/41 (87.80%)
The following tags are not tested by the test suite:
diff --git a/t/tests/shared-libs-control-file/debian/debian/rules b/t/tests/shared-libs-control-file/debian/debian/rules
index 80a2523..b8f1844 100644
--- a/t/tests/shared-libs-control-file/debian/debian/rules
+++ b/t/tests/shared-libs-control-file/debian/debian/rules
@@ -10,7 +10,7 @@ override_dh_builddeb:
# before installing them.
rm -f debian/libnoshf1/DEBIAN/shlibs
echo "# aloha" > debian/libeshf1/DEBIAN/shlibs
- echo "libfoo 1 libunshf1" >> debian/libunshf1/DEBIAN/shlibs
+ echo "libfoo 1 libunshf1 (> 0.1)" >> debian/libunshf1/DEBIAN/shlibs
sed -i 's/libfdshf1/libforeign1/' debian/libfdshf1/DEBIAN/shlibs
cat $(DUPSHF) $(DUPSHF) > $(DUPSHF).tmp
mv -f $(DUPSHF).tmp $(DUPSHF)
diff --git a/t/tests/shared-libs-control-file/desc b/t/tests/shared-libs-control-file/desc
index 78071c6..4a5cfb3 100644
--- a/t/tests/shared-libs-control-file/desc
+++ b/t/tests/shared-libs-control-file/desc
@@ -7,4 +7,5 @@ Test-For:
no-shlibs-control-file
shlib-missing-in-control-file
shlibs-declares-dependency-on-other-package
+ shlibs-uses-obsolete-relation
unused-shlib-entry-in-control-file
diff --git a/t/tests/shared-libs-control-file/tags b/t/tests/shared-libs-control-file/tags
index 36055f3..6838c4d 100644
--- a/t/tests/shared-libs-control-file/tags
+++ b/t/tests/shared-libs-control-file/tags
@@ -2,4 +2,5 @@ E: libdupshf1: duplicate-entry-in-shlibs-control-file libdupshf 1
E: libeshf1: shlib-missing-in-control-file libeshf 1 for usr/lib/libeshf.so.1.0.1
E: libnoshf1: no-shlibs-control-file usr/lib/libnoshf.so.1.0.1
W: libfdshf1: shlibs-declares-dependency-on-other-package libforeign1
+W: libunshf1: shlibs-uses-obsolete-relation libunshf1 (> 0.1)
W: libunshf1: unused-shlib-entry-in-control-file libfoo 1
--
Debian package checker
Reply to: