Bug#633887: lintian: Perl warnings from reporting/harness -f

[Niels Thykier <niels@thykier.net>]

On 2011-07-14 21:06, Adam D. Barratt wrote:
> On Thu, 2011-07-14 at 11:22 -0700, Russ Allbery wrote:
>> This may already be fixed with the work that was done on master; if so,
>> feel free to close.
>>
>> Running reporting/harness -f on lintian.debian.org with 2.5.1 produced the
>> following Perl warnings:
>>
>> Use of uninitialized value $ENV{"LINTIAN_ROOT"} in concatenation (.) or string at /org/lintian.debian.org/root/lib/Read_pkglists.pm line 25.
> 
> Hmmm.  That's
> 
> 	use lib "$ENV{'LINTIAN_ROOT'}/lib";
> 
> That statement is no longer in Read_pkglists.pm, but reporting/harness
> should be setting $LINTIAN_ROOT in any case, so I'm intrigued as to
> what's going on here.
> 

I think I get this one; looking at reporting/harness it does not set
$ENV{LINTIAN_ROOT} before the require statement.  Though
reporting/harness has to do that part itself, so Read_pkglists still
worked at the point.

>> Use of uninitialized value in numeric eq (==) at /org/lintian.debian.org/root/unpack/list-srcpkg line 140, <IN> line 746.
>> Use of uninitialized value in numeric eq (==) at /org/lintian.debian.org/root/unpack/list-srcpkg line 140, <IN> line 7558.
> 
> These are both:
> 
>       if ($timestamp == $data->{'timestamp'}) {
> 
> $timestamp is determined by stat()ing the .dsc, so I assume it's the %
> data reference which is failing.  That implies that the previous version
> of the package list included a record for the source package but with no
> timestamp, which also doesn't sound right.
> 
> Regards,
> 
> Adam
> 
> 
> 
> 

~Niels