--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: lintian: [checks/patch-systems] Add test for README.source
- From: Jonathan Yu <frequency@cpan.org>
- Date: Tue, 21 Jul 2009 22:36:09 -0400
- Message-id: <20090722023609.23411.24132.reportbug@ip-64-15-147-134.static.privatedns.com>
Package: lintian
Version: 2.2.12
Severity: wishlist
Tags: patch
Hi:
This is actually just a partial patch. I can add the tests, but I don't know where
tags are defined. Basically, this test ensures that if you are using a patch system,
you provide instructions on how to use it (via README.source), per Standards-Version
> 3.8.0.
It's a relatively simple patch:
--- a/checks/patch-systems
+++ b/checks/patch-systems
@@ -166,6 +166,13 @@ sub run {
}
}
+ #----- look for README.source
+ if ($uses_patch_system && ! -f debian/README.source) {
+ tag "patch-system-but-no-source-readme";
+ }
+ if (!$uses_patch_system && -f debian/README.source) {
+ tag "source-readme-but-no-patch-system";
+ }
#----- general cruft checking:
if ($uses_patch_system > 1) {
The problem is that I don't know where tags are defined. Also, in order for the
patch to really be useful, it needs to be able to detect what Standards-Version
the package is under, since it's only relevant for Standards-Version > 3.8.0.
I couldn't find anything to do that in a cursory search of the POD files.
I tried to grep on my git repository for the tag list, but can't find it. Here
is some recommended text for those tags:
patch-system-but-no-source-readme
Certainty: certain
N: It looks like a patch system is in use, however there is no
N: debian/README.source. This file is required by Debian Policy 3.8.0.
source-readme-but-no-patch-system
Certainty: certain
N: It does not look like a patch system is in use, however there is an
N: included debian/README.source. This is probably the remnants of a
N: removed patch, and is not necessary.
-- System Information:
Debian Release: squeeze/sid
APT prefers testing
APT policy: (500, 'testing'), (500, 'stable'), (1, 'experimental'), (1, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.24-1-686 (SMP w/2 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 2.2.14
We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive:
lintian_2.2.14.dsc
to pool/main/l/lintian/lintian_2.2.14.dsc
lintian_2.2.14.tar.gz
to pool/main/l/lintian/lintian_2.2.14.tar.gz
lintian_2.2.14_all.deb
to pool/main/l/lintian/lintian_2.2.14_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 537969@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Russ Allbery <rra@debian.org> (supplier of updated lintian package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sat, 15 Aug 2009 22:47:44 -0700
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.2.14
Distribution: unstable
Urgency: low
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Russ Allbery <rra@debian.org>
Description:
lintian - Debian package checker
Closes: 469018 492626 534942 536397 536404 536405 537207 537606 537607 537608 537969 538055 538929 540348 540425 541119 541143 541144
Changes:
lintian (2.2.14) unstable; urgency=low
.
The "Policy 3.8.3" release.
.
* Summary of tag changes:
+ Added:
- debhelper-overrides-need-versioned-build-depends
- maintainer-script-modifies-ld-so-conf
- missing-dependency-on-install-info
- multiple-distributions-in-changes-file
- patch-system-but-no-source-readme
- package-modifies-ld.so-search-path
- possible-documentation-but-no-doc-base-registration
+ Removed:
- file-in-usr-something-x11-without-pre-depends
+ Renamed:
- build-depends-on-x-metapackage => build-depends-on-metapackage
- depends-on-x-metapackage => depends-on-metapackage
.
* checks/changelog-file.desc:
+ [RA] Document the "Old Changelog" way of marking historic changelog
entries that shouldn't be syntax-checked in the long description for
syntax-error-in-debian-changelog. (Closes: #541119)
* checks/debconf:
+ [CW] Permit Help: in .templates files, which is supported as of
cdebconf 0.143 and used in the installer.
* checks/debhelper{,.desc}:
+ [CW] Check for the use of debhelper override targets, which require
debhelper 7.0.50.
+ [RA] Don't warn about recently deprecated debhelper commands in
possibly optional portions of debian/rules. (Closes: #537607)
+ [RA] Don't warn about missing build dependencies for commands in
possibly optional portions of debian/rules. (Closes: #537608)
* checks/description:
+ [RA] Decode descriptions from UTF-8 before checking length. Thanks,
Charles Plessy. (Closes: #537207)
+ [RA] Avoid duplicated word false positives from words that contain
punctuation. Thanks, Nelson A. de Oliveira. (Closes: #540348)
* checks/fields{,.desc}:
+ [FL] packages named lib*-camlp4-dev should be in section ocaml
+ [RA] Move debian/rules parsing to check build dependencies to
checks/rules.
+ [RA] Allow any package to be in section oldlibs without triggering
warnings. Thanks, Rene Engelhard. (Closes: #537606)
+ [RA] Lower wrong-section-according-to-package-name to possible.
+ [RA] Recognize packages as metapackages even if they contain Lintian
overrides, thus fixing two packages that added a Lintian override
for having dependencies only permitted for metapackages, which in
turn ensures that they keep getting that tag.
+ [RA] Recognize packages as metapackages even if they contain files
in /usr/share/cdd.
+ [RA] Renamed the tags for depending or build-depending on X
metapackages to make them generic and load the list of metapackages
from data/fields/metapackages. Always consider known metapackages
to be metapackages for the dependency check.
+ [RA] Don't require a tilde after lp: in bzr URLs. Thanks, Benjamin
Drung. (Closes: #541143)
+ [RA] Fix spelling of xfonts-encodings in the xfont dependency
exception. (Closes: #540425)
+ [RA] Allow :ext: CVS repository references if the username looks
like it won't require autentication. Thanks, Thorsten Glaser.
* checks/files{,.desc}:
+ [CW] /var/lock and /var/run are not temporary filesystems in d-i, so
don't emit errors about their use in udebs.
+ [RA] Warn about packages containing files in /etc/ld.so.conf.d that
don't appear to be part of libc. Policy 3.8.3 no longer permits
modification of ld.so.conf.
+ [RA] Remove the check for x11-common pre-depends before installing
files in /usr/{include,lib}/X11. Policy 3.8.3 removes this
requirement.
* checks/infofiles{,.desc}:
+ [RA] Add missing leading * to example info directory entry.
+ [RA] Check that packages with info files depend on dpkg or
install-info as recommended by Policy 5.8.3.
* checks/lintian.desc:
+ [RA] Expand multiple-distributions-in-changes-file description and
add a reference to the Policy section. Change certainty to
possible, since this may be fine for non-Debian uploads.
* checks/menus{,.desc}:
+ [RA] Add info-level tag for packages with apparent HTML or PDF
documentation in /usr/share/doc but no doc-base registration. Based
on a patch from Raphael Geissert. (Closes: #469018)
* checks/patch-systems{,.desc}:
+ [RA] Check for a patch system in use but no debian/README.source.
Based on a patch from Jonathan Yu. (Closes: #537969)
* checks/po-debconf:
+ [CW] Don't emit not-using-po-debconf if all templates are marked "for
internal use". (Closes: #492626)
* checks/rules{,.desc}:
+ [RA] Moved checking of build dependencies based on programs invoked
in debian/rules from checks/fields to here.
+ [RA] Expand Lintian's understanding of which targets are run for the
clean target to include targets invoked via pattern variable
expansion. (Closes: #536405)
+ [RA] Make the handling of make variables as rule names more robust
and avoid generating invalid regexes.
+ [RA] Packages including /usr/share/mozilla-devscripts makefile
fragments in debian/rules must Build-Depend on mozilla-devscripts.
Thanks, Benjamin Drung. (Closes: #541144)
* checks/scripts:
+ [RA] Fix parsing of dpkg-divert commands diverting a file ending in
a number, followed by a redirection. Thanks, Andreas Beckmann.
(Closes: #534942)
+ [RA] Warn about maintainter scripts that modify /etc/ld.so.conf.
Policy 3.8.3 no longer permits this.
+ [RA] Avoid command-with-path-in-maintainer-script false positives
with backtick expressions as arguments to commands. Thanks, Stefan
Fritsch. (Closes: #536397)
* checks/watch-file:
+ [RA] Fix false positives in debian-watch-file-should-mangle-version
when an upstream version is specified in the watch file and give the
line number of mangling issues. Patch from Raphael Geissert.
(Closes: #536404)
.
* data/debhelper/*:
+ [ADB] Refresh against unstable.
* data/fields/architectures:
+ [RA] Refresh architecture list against dpkg 1.15.3.1, adding avr32
and kopensolaris. (Closes: #538055)
* data/fields/metapackages:
+ [RA] New file listing known metapackages that should not be used in
Depends or Build-Depends.
+ [RA] Add mono-complete. (Closes: #538929)
* data/fields/virtual-packages:
+ [ADB] Refresh against unstable.
* data/files/fonts:
+ [ADB] Refresh against unstable.
* data/standards-version/release-dates:
+ [RA] Add the release date for Policy 3.8.3.
.
* debian/control:
+ [RA] Update standards version to 3.8.3 (no changes required).
.
* frontend/lintian:
+ [RA] Enable multiple-distributions-in-changes-file now that Policy
documents that this does not work with the Debian archive.
* frontend/lintian-info:
+ [ADB] Correctly parse Lintian output for pedantic tags. Thanks, James
Vega.
.
* lib/Spelling.pm:
+ [RA] Add spelling correction for precedence.
.
* reporting/html_reports:
+ [JP] Accumulate tag-specific statistics in a new variable, and pass it
to the appropriate templates.
* reporting/templates/tags{,-severity}.tmpl:
+ [JP] Remove duplicate code to calculate tag statistics.
.
* t/runtests:
+ [RA] Update standards version to 3.8.3.
Checksums-Sha1:
d8034578bac4c674ec397749f650056a4504dcd9 1167 lintian_2.2.14.dsc
a3f7446c625a218195716e7f9fd896383cba8123 731798 lintian_2.2.14.tar.gz
0e1f6f4d845bb760f19ea8464cb0ac63236715ca 468394 lintian_2.2.14_all.deb
Checksums-Sha256:
fc372c8963ac7d2c22dbfda0f45ecd029fdc4f1347d5dbb3b83bb3dd920b69ce 1167 lintian_2.2.14.dsc
48d31b91ee78ad47c0a5a4cae2532d002d23c364826b227519226e9785be2793 731798 lintian_2.2.14.tar.gz
d40a2c8772b0a8e037665f5ea20aed0a76f7e2799de54d18882608ded01ed21d 468394 lintian_2.2.14_all.deb
Files:
c0b4d6209d27123a5705fec67f1b0c58 1167 devel optional lintian_2.2.14.dsc
98f3764c0064bbbd1ab395151bbff0c5 731798 devel optional lintian_2.2.14.tar.gz
c2a4e455f92e8514fee6fea2c6d3fe08 468394 devel optional lintian_2.2.14_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkqHncwACgkQ+YXjQAr8dHZuyQCdHutP/W/IX+kBKJpwzGc/7cE3
YJQAniZHgniQzQcR1F2J1SkBNqMzngcb
=IWDa
-----END PGP SIGNATURE-----
--- End Message ---