Re: tests framework refactoring

["Adam D. Barratt" <adam@adam-barratt.org.uk>]

On Fri, 2009-05-08 at 14:21 -0500, Raphael Geissert wrote:
> Attached lintian-tests.mbox includes some of the changes Russ and I
> discussed about running the t/scripts test first and so on. More
> refactoring should come later, but I think this is a good start point.

Thanks for the patches.  I've applied all three, although with some
fixes to "[PATCH 2/3] Change the order by which tests are run";
specifically, from the patch:

+my @tests;
+my $prev;
+
+# --- Run all test scripts

The following therefore appears to be equivalent to "$prev=0" :-) ($prev
is undefined and @tests is empty, even before you explicitly make it
empty again).  This stanza is, however, required at the start of the
"changes" test section.

+$prev = $prev || scalar(@tests);
+@tests = ();

[stuff not modifying $prev]
+print "\n" if ($prev and @tests);

At this point $prev is always 0 anyway; I've moved the print inside the
test loop.

> lintian-overrides-tests.mbox is a test for malformed-overrides and other
> overrides-related checs I somehow forgot to submit (look at the date :).

Applied, thanks.

Regards,

Adam