[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Some more t/scripts tests



On Sun, 2009-05-03 at 19:46 -0500, Raphael Geissert wrote:
> Adam D. Barratt wrote:
> > 
> > It's possible I'm being overly picky here, but I have to admit that I'd
> > prefer it if the test script and the changes to existing files as a
> > result of issues found by the script were two commits rather than being
> > bundled in to one.
> 
> Do you have any special reason? I've nothing against doing it the way you
> say, but by including both changes in the same commit it makes a clear
> point as to why those changes were made and based on what.

Not that I can clearly describe, no, hence the prefix to the comment.
It just "feels nicer" to me, but obviously ymm (and does :) v.

Regards,

Adam


Reply to: