[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#349616: still here - checks/debconf: false alarm about settitle



Hi,

I've finally managed to give the proposed changes a try.

The result is that the bug seems to be gone -- having Depends: line like
   debconf (>= 0.5) | debconf-2.0,
   debconf (>= 1.4.69) | cdebconf (>= 0.43)
no longer gives settitle-requires-versioned-depends, suggesting to use
"debconf (>= 1.3.22) | cdebconf (>= 0.43)"

I attach the patch for reference.

Since you mentioned a test suite, I've given the debconf portion of it a
try. I got one unrelated (IMHO) error:

$ testset/runtests -k testset . debconf
Checking for missing info tags ... done.
Running static lab test ... create ...  renew ...  remove ... rmdir ...done.
Running test on debconf 1~rc1: copying... building... testing... FAILED:
--- testset/tags.debconf        2007-03-10 08:55:52.000000000 +0200
+++ ./tags.debconf      2007-03-23 22:40:23.000000000 +0200
@@ -15,8 +15,8 @@
 W: debconf source: misnamed-po-file debian/po/sample-file.po
 W: debconf source: newer-debconf-templates
 W: debconf source: stray-translated-debconf-templates
debconf-test.templates.de-W: debconf source: translated-default-field
debconf-test.templates: 67
-W: debconf source: translated-default-field debconf-test.templates: 72
+W: debconf source: translated-default-field debconf-test.templates: 70
+W: debconf source: translated-default-field debconf-test.templates: 75
 W: debconf source: unknown-encoding-in-po-file debian/po/fr.po
 W: debconf-test-noscripts: no-debconf-config
 W: debconf-test-noscripts: old-fsf-address-in-copyright-file
Checking whether all tags are tested and tags have description ...
done.


I hope this helps a little bit,
	dam
-- 
Damyan Ivanov                           Modular Software Systems
phone +359(2)928-2611, 929-3993              fax +359(2)920-0994
mobile +359(88)856-6067              JID dam@jabber.minus273.org
diff -ru lintian-1.23.28/checks/debconf lintian-1.23.28+0/checks/debconf
--- lintian-1.23.28/checks/debconf	2007-03-10 08:55:47.000000000 +0200
+++ lintian-1.23.28+0/checks/debconf	2007-03-22 23:32:37.000000000 +0200
@@ -107,16 +107,10 @@
 	chomp($_ = <IN>);
 	close IN;
 	$_ .= ", $version" if defined $version;
-	$_ =~ s/debconf-2\.0/debconf (>= 1.2.30)/go;
-	$_ =~ s/cdebconf(-\w+)?(-udeb)?\s*(\(.+?\))?/debconf (>= 1.2.30)/g;
-	$_ =~ s/libdebconfclient.?(-udeb)?\s*(\(.+?\))?/debconf (>= 1.2.30)/g;
         push @alldeps, $_;
 	$dependencies{$field} = Dep::parse($_);
     } else {
 	my $dep = $version;
-	$dep =~ s/debconf-2\.0/debconf (>= 1.2.30)/go;
-	$dep =~ s/cdebconf(-\w+)?(-udeb)?\s*(\(.+?\))?/debconf (>= 1.2.30)/g;
-	$dep =~ s/libdebconfclient.?(-udeb)?\s*(\(.+?\))?/debconf (>= 1.2.30)/g;
 	push @alldeps, $dep;
 	$dependencies{$field} = Dep::parse($dep);
     }
@@ -399,7 +393,7 @@
 	    }
 	    if (not $usessettitle and m/db_settitle\s+/) {
 		unless (Dep::implies($alldependencies,
-				     Dep::parse('debconf (>= 1.3.22)'))) {
+				     Dep::parse('debconf (>= 1.3.22) | cdebconf  (>= 0.43)'))) {
 	           tag "settitle-requires-versioned-depends", "$file" 
 		       unless $type eq 'udeb';
 	       }
@@ -439,13 +433,17 @@
 
 # Check that the right dependencies are in the control file.
 
+my $anydebconf = 'debconf | debconf-2.0 | cdebconf | cdebconf-udeb'
+  . ' | libdebconfclient0 | libdebconfclient0-udeb';
 if ($usespreinst) {
-    unless (Dep::implies($dependencies{'pre-depends'}, Dep::parse('debconf'))) {
+    unless (Dep::implies($dependencies{'pre-depends'},
+                Dep::parse($anydebconf))) {
 	tag "missing-debconf-dependency-for-preinst", ""
 	    unless $type eq 'udeb';
     }
 } else {
-    unless (Dep::implies($alldependencies, Dep::parse('debconf')) or $usesdbconfig) {
+    unless (Dep::implies($alldependencies,
+                Dep::parse($anydebconf)) or $usesdbconfig) {
 	tag "missing-debconf-dependency", "";
     }
 }

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: