[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#353294: lintian: the probably-uses-debconf test fails too often



Thomas Huriaux <thomas.huriaux@gmail.com> writes:

> The probably_uses_debconf test (in check/po-debconf) still fails in many
> cases, especially when the maintainer uses dh_installdebconf and
> ${misc:Depends} (for example, #352948 would have been avoided if the
> test had not failed).

> Please find attached two patches, they are different ways to fix the
> problem:
> * po-debconf.depends.diff adds different tests such as the presence of
>   Build-Depends: po-debconf, the use of dh_installdebconf, ...
> * po-debconf.strict.diff removes all the tests but the $has_templates
>   test, and assume that the package uses Debconf if this test returns
>   true.

> While the first patch should avoid potential false-positives if a
> maintainer uses a file 'debian/foo.templates' that is not related with
> Debconf, I strongly recommend to use the second patch. There is
> currently no false-positive (thanks to Denis Barbier who checked the
> source packages), this patch greatly simplifies the check and is very
> efficient to avoid false-negatives.

Given that you've already checked all the source packages, this sounds
like the right fix to me.  Committed.

-- 
Russ Allbery (rra@debian.org)               <http://www.eyrie.org/~eagle/>



Reply to: