Re: [RFR] templates://insserv/{insserv.templates}
Christian Perrier wrote:
> Your review should be sent as an answer to this mail.
Just out of interest, does anybody know why it's called "insserv"?
> Template: insserv/enable
[...]
> + If you choose to enable the dependency-based boot sequence,
> + all the scripts in /etc/rc*.d/ that use dependency information will be
> + reordered. If such information
> + is missing, default dependency info will be used. All S* symlinks in rc0.d/
s/ info / information /? Except that that makes it repetitive.
Indeed, now I think about it, the question isn't whether the scripts
*use* dependency information, it's whether they *give* it in LSB
headers. It also seems to be claiming that the scripts without
headers won't be involved in the reordering... maybe:
If you choose to enable the dependency-based boot sequence the
scripts in /etc/rc*.d/ will be reordered using dependency
information provided by LSB comment headers (or defaults where
these are not present). [...]
> + and rc6.d/ will be turned into K* symlinks, to make
> sure the way they are used (with 'stop' argument) matches their
That parenthetical bit should probably be "with the argument
'stop'".
> + names. The change will only be done after it is verified that it is
> + safe to convert. Disabling it when enabled will try to revert the
> change.
I don't like this phrasing where it's the disabling that does the
trying, but I can't find a fix that doesn't sound worse.
> + Please note that this feature is experimental. Reverting from
> + dependency-based boot sequencing is not supported and may require the
> + reinstallation of the system.
Reverting is supported in the sense that a mechanism is provided
which will "try" to do it; users need to be warned that there's a
genuine risk it might fail. Something like:
Please note that this feature is experimental. Attempting to revert
from dependency-based boot sequencing is not guaranteed to be safe,
and may require the reinstallation of the system.
> Package: insserv
[...]
> +Description: boot sequence ordering based on LSB init.d script dependencies
Sequence ordering seems redundant; and insserv isn't the ordering.
Perhaps we could say:
Description: boot sequence switcher using LSB init.d script dependencies
> + This utility reorders the init.d boot scripts based on dependencies
> + mentioned in scripts' LSB comment headers or override files
> + included in this package or in /etc/.
False friend: s/mentioned/given/. When it says "/etc/" it means
"/etc/insserv/(overrides/)".
given in scripts' LSB comment headers, or in override files
included in this package or added in /etc/insserv.
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
--- ../insserv.old/debian/insserv.templates 2008-01-14 12:07:03.000000000 +0000
+++ debian/insserv.templates 2008-01-21 16:05:07.000000000 +0000
@@ -1,20 +1,16 @@
Template: insserv/enable
Type: boolean
-_Description: Enable (or keep enabled) dependency based boot sequence?
- Enabling this will reorder all the scripts in /etc/rc*.d/ using the
- dependency information provided in each script. If such information
- is missing, default dependency info will be used. It will also
- change all S* symlinks in rc0.d/ and rc6.d/ to K* symlinks, to make
- sure the way they are used (with 'stop' argument) matches their
- names. The change will only be done after it is verified that it is
- safe to convert. Disabling it when enabled will try to revert the
+_Description: Enable (or keep enabled) the dependency-based boot sequence?
+ If you choose to enable the dependency-based boot sequence the
+ scripts in /etc/rc*.d/ will be reordered using dependency
+ information provided by LSB comment headers (or defaults where
+ these are not present). All S* symlinks in rc0.d/
+ and rc6.d/ will be turned into K* symlinks, to make
+ sure the way they are used (with the argument 'stop') matches their
+ names. The change will only be done after it is verified that it is
+ safe to convert. Disabling it when enabled will try to revert the
change.
.
- WARNING: It is very hard to revert from dependency based boot
- sequencing to the non-dependency based boot sequencing.
- Reinstallation might be required.
- .
- This is an experimental feature, and is at the moment only intended
- for testing of insserv and the LSB style dependecy information in
- init.d scripts.
-
+ Please note that this feature is experimental. Attempting to revert
+ from dependency-based boot sequencing is not guaranteed to be safe,
+ and may require the reinstallation of the system.
--- ../insserv.old/debian/control 2008-01-14 12:07:05.000000000 +0000
+++ debian/control 2008-01-21 16:24:11.000000000 +0000
@@ -12,10 +12,10 @@
Depends: ${shlibs:Depends}, ${misc:Depends}, sysv-rc
Suggests: bootchart
Conflict: initscripts (<< 2.86.ds1-48)
-Description: Reorder boot sequence based on LSB init.d script dependencies
- Reorder the boot order based on init.d script dependencies as
- documented in LSB comment headers in the script or in override files
- included in the package or in /etc/.
+Description: boot sequence switcher using LSB init.d script dependencies
+ This utility reorders the init.d boot scripts based on dependencies
+ given in scripts' LSB comment headers, or in override files
+ included in this package or added in /etc/insserv.
.
- Use this package with care, as incorrect or missing dependencies can
- give you an unbootable system.
+ This package should be used with care, as incorrect or missing dependencies
+ can lead to an unbootable system.
Template: insserv/enable
Type: boolean
_Description: Enable (or keep enabled) the dependency-based boot sequence?
If you choose to enable the dependency-based boot sequence the
scripts in /etc/rc*.d/ will be reordered using dependency
information provided by LSB comment headers (or defaults where
these are not present). All S* symlinks in rc0.d/
and rc6.d/ will be turned into K* symlinks, to make
sure the way they are used (with the argument 'stop') matches their
names. The change will only be done after it is verified that it is
safe to convert. Disabling it when enabled will try to revert the
change.
.
Please note that this feature is experimental. Attempting to revert
from dependency-based boot sequencing is not guaranteed to be safe,
and may require the reinstallation of the system.
Source: insserv
Section: misc
Priority: optional
Maintainer: Petter Reinholdtsen <pere@debian.org>
Build-Depends: debhelper (>= 4.0.0), po-debconf, dpatch
Standards-Version: 3.7.3
Vcs-Svn: svn://svn.debian.org/initscripts-ng/trunk/src/insserv
Vcs-Browser: http://svn.debian.org/wsvn/initscripts-ng/trunk/src/insserv
Package: insserv
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, sysv-rc
Suggests: bootchart
Conflict: initscripts (<< 2.86.ds1-48)
Description: boot sequence switcher using LSB init.d script dependencies
This utility reorders the init.d boot scripts based on dependencies
given in scripts' LSB comment headers, or in override files
included in this package or added in /etc/insserv.
.
This package should be used with care, as incorrect or missing dependencies
can lead to an unbootable system.
Reply to: