Re: [PATCH v3] deb-pkg: add source package
On 21 August 2015 at 15:38, Michal Marek <mmarek@suse.cz> wrote:
>
> On Fri, Aug 21, 2015 at 11:08:44AM +0200, Ben Hutchings wrote:
> > I've gone through this with Riku and found a couple of problems:
> >
> > - The 'clean' rule in the generated debian/rules calls 'make clean',
> > but scripts/package/Makefile includes debian/ in clean-dirs.
> > Currently that directory does not get removed for some reason, but I
> > think that's a bug and the clean rule in debian/rules should guard
> > against removal.
>
> Good catch. make clean is indeed supposed to delete the debian/
> directory.
It looks like debian/ directory isn't cleaned because "scripts" is
missing from "clean-dirs" in
the kernel top-level Makefile - it is in mroper-dirs, and thus debian/
vanishes when "make mrproper"
is run. I'm quite surprised that "clean-dirs" in toplevel makefile
means "recurse" but deeper in directory
tree it starts meaning "rm -rf this"..
If clean-dirs is fixed to remove debian/, this will be annoying to fix
in this patch.
> > - Building of the 'orig' tarball uses git, i.e. it depends on the
> > kernel source being in a git repository and not simply unpacked from
> > a tarball (or from other VCS). The rpmpkg target doesn't have this
> > same restriction.
>
> Right. make rpm uses the KBUILD_ALLDIRS to generate the tarball. It's
> not perfect, but it behaves consistently.
Changing this to match rpmpkg behaviour makes sense.
Reply to: