[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#621032: linux-2.6: please add armhf support



On Sun, 2011-04-17 at 11:39 +0200, Hector Oron wrote:
[...]
> ##
> ## file: arch/arm/Kconfig
> ##
> ## choice: ARM system type
> # CONFIG_ARCH_REALVIEW is not set
> ## end choice
> CONFIG_AEABI=y
> CONFIG_OABI_COMPAT=y

Is OABI_COMPAT still important?

[...]
> ##
> ## file: net/econet/Kconfig
> ##
> CONFIG_ECONET_AUNUDP=y
> CONFIG_ECONET_NATIVE=y

We already disabled ECONET; this is just cruft in the armel config.

[...]
> ##
> ## file: "kernel/time/Kconfig"
> ##
> #. Need to check if this are needed or selected by other symbols.
> #. CONFIG_NO_HZ=y
> #. CONFIG_HIGH_RES_TIMERS=y

These are already set in the master config (debian/config/config).

> #. Need to cross-check with rtp if we need split regions.
> CONFIG_VMSPLIT_3G=y
> CONFIG_PAGE_OFFSET=0xC0000000

Why?  And you'd better enable HIGHMEM unless these machines are
definitely limited to 1GB RAM.

> #. At top level CONFIG_HZ_250=y found
> #. CONFIG_HZ=100

So why mention it?

> #. Force console from kernel cmdline
> CONFIG_CMDLINE="console=ttymxc0,115200 console=tty1"

No, leave it to the boot loader.

> ##
> ## file: "drivers/Kconfig"
> ##
> ## file: "drivers/base/Kconfig"
> #. CONFIG_DEVTMPFS is not set

Why?

> #. CONFIG_STANDALONE is not set
> #. CONFIG_PREVENT_FIRMWARE_BUILD is not set

Why?  We strip all the firmware so there is no way firmware could be
built.

[...]
> ## file: "drivers/mtd/Kconfig"
> #. Do we need this?
> #. CONFIG_MTD=y
> #. CONFIG_MTD_CONCAT=y
> #. CONFIG_MTD_PARTITIONS=y
> #. CONFIG_MTD_CMDLINE_PARTS=y
> #. CONFIG_MTD_CHAR=y
> #. CONFIG_MTD_BLOCK=y

If most systems are going to need MTD then you should make MTD and
MTD_CHAR built-in.  Otherwise, they'll be included in the initramfs if
necessary.

[...]
> ## file: "drivers/ide/Kconfig"
> #. CONFIG_HAVE_IDE=y

What?

> ## file: "drivers/scsi/Kconfig"
> #. XXX Needed to promote to main config?
> CONFIG_SCSI_MOD=y

Never set SCSI_MOD directly; only set SCSI.

[...]
> ## file: "drivers/i2c/Kconfig"
> #. XXX It need to check whether is needed
> #. CONFIG_I2C=y
> #. CONFIG_I2C_BOARDINFO=y
> #. CONFIG_I2C_CHARDEV=y
> #. CONFIG_I2C_ALGOBIT=y
> #. CONFIG_I2C_ALGOPCF=y
> #. CONFIG_I2C_ALGOPCA=y
[...]

I2C and the various algorithm modules should be selected by other
drivers as necessary.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: