Re: RFS - node-fast-json-stable-stringify

[Yadd <yadd@debian.org>]

On 7/18/23 05:26, michael wrote:
> Hello,
> Please, I am requesting sponsorship for a new package.
>
> Package name: node-fast-json-stable-stringify
> version: 2.1.0-1
> closes: #1041347
> salsa repo: 
> https://salsa.debian.org/mikemando/node-fast-json-stable-stringify 
> <https://salsa.debian.org/mikemando/node-fast-json-stable-stringify>
>
> I have built the package using sbuild and ensured that it is lintian clean.
>
> Thank you.

Hi,

* copyright is wrong, see LICENSE
* bad test, why use nyc + npm to launch a simple test ?
  `tape test/*.js` is enough here, clean also build dependencies
  (+ this fixes autopkgtest)
* mark test dependencies with <!nocheck>
* drop useless empty dependency

Cheers,
Yadd