[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: haskell-knob



On 05/26/2012 09:11 AM, Joachim Breitner wrote:
> Hi John,
> 
> no need to CC me, I read d-haskell.
> 
> 
> Am Samstag, den 26.05.2012, 09:02 -0700 schrieb John Millikin:
>> On Sat, May 26, 2012 at 8:47 AM, Joachim Breitner <nomeata@debian.org> wrote:
>>> Hi John,
>>>
>>> I discovered two „Ready to upload“ packages on PET from you and had a
>>> look.
>>>
>>> I did not see any darcs commit messages on pkg-haskell-commits for them.
>>> Did you set up the darcs hooks as described on the Wiki?
>>
>> Ah, sorry, I misread the Wiki and ran add-hooks with no package name.
>> Fixed for haskell-{knob,ncurses,options,patience}
> 
> Thanks.
> 
>>> I noticed that your haskell-knob watch file points to a .tar.xz file,
>>> while on hackage there is a tar.gz file. Is there a reason why you
>>> cannot just point to hackage? This has the advantage that all watch
>>> files stay identical (besides the package name, of course) and we could
>>> easily do mass updates.
>>
>> I don't like using Hackage, because the packages aren't signed or
>> checksummed. All of the files on my site have checksums and GPG
>> signatures, and are served via HTTPS.
> 
> Hmm, reasonable. I added support for .xz files to pkg-haskell-checkout.
> 
>>> Also, I see that in the haskell-options package, you did not fully
>>> reflect the versioning constraints from the cabal file in
>>> debian/control. (The upper bound on system-filepath is missing.) Right
>>> now, with the mtl/transformers transition, I noticed how important that
>>> is. Can you fix that?
>>
>> Oops, sorry. Fixed.
> 
> -knobs uploaded, for -options I wait until the build dependencies have
> been rebuild. Also, I added a build-dependency on ghc-ghci because of
> the use of Template Haskell.
> 
> Greetings,
> Joachim
> 

Gentle ping; if I'm reading the debian-haskell buildd status page
correctly, then all of the dependencies for haskell-options have
finished rebuilding. Is there anything else I should do to make it ready
for upload?

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: