[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1069065: gcc-14: should -for-host builds move from cross-toolchain build to DEB_STAGE=rtlibs?



Hi,

On Mon, 15 Apr 2024 18:10:16 +0200 Helmut Grohne <helmut@subdivi.de> wrote:
Which gcc builds should emit -for-host packages?
[...]
I have added this patch to rebootstrap now and it has generally improved bootstrapping. In particular, gcc-N-for-host is practically coinstallable.
I find your reasoning convincing and had a look at the patch. The patch also looks reasonably sane to me. There is a typo near the end ("disbaled" instead of "disabled"), which does not influence runtime behavior because the variable is only checked for equality with "yes".

Moving build logic to binary-forhost.mk gets rid of quite a lot of code duplication (the do_for_host_package macro becomes the authoritative source), which I consider a Good Thing. Ultimately, it is the maintainer's judgement call whether they want it like this or would rather change the conditional inclusion logic to have the -for-host package build logic reside with the respective language addon Makefiles.


Cheers
Timo

--
⢀⣴⠾⠻⢶⣦⠀   ╭────────────────────────────────────────────────────╮
⣾⠁⢠⠒⠀⣿⡁   │ Timo Röhling                                       │
⢿⡄⠘⠷⠚⠋⠀   │ 9B03 EBB9 8300 DF97 C2B1  23BF CC8C 6BDD 1403 F4CA │
⠈⠳⣄⠀⠀⠀⠀   ╰────────────────────────────────────────────────────╯

Attachment: signature.asc
Description: PGP signature


Reply to: