[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1032183: marked as done (libgusb-dev: missing dependency on libjson-glib-1.0-dev)

Your message dated Wed, 12 Apr 2023 14:39:38 +0000
with message-id <E1pmbdK-002TFN-VV@fasolo.debian.org>
and subject line Bug#1032183: fixed in libgusb 0.4.5-1.1
has caused the Debian Bug report #1032183,
regarding libgusb-dev: missing dependency on libjson-glib-1.0-dev
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1032183: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1032183
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: libgusb-dev
Version: 0.4.5-1
Severity: serious
Justification: Policy 7.2

To reproduce:

* Have a minimal Debian chroot or container
* apt install libgusb-dev
* pkg-config --cflags --libs gusb

Expected result: success, compiler flags are shown

Actual result:

> + pkg-config --cflags --libs gusb gobject-2.0 glib-2.0
> Package json-glib-1.0 was not found in the pkg-config search path.
> Perhaps you should add the directory containing `json-glib-1.0.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'json-glib-1.0', required by 'gusb', not found

I'll send the obvious patch when I have a bug number.

It's easy to reproduce this class of issues with an autopkgtest like
the one added by the attached patch, and running autopkgtest before upload
can detect and prevent these missing dependencies before they reach Debian.

    smcv

-- System Information:
Debian Release: bookworm/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'stable-security'), (500, 'oldstable-debug'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.1.0-5-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8), LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libgusb-dev depends on:
ii  gir1.2-gusb-1.0     0.4.5-1
ii  libc6               2.36-8
ii  libglib2.0-0        2.74.5-1
ii  libglib2.0-dev      2.74.5-1
ii  libgusb2            0.4.5-1
ii  libjson-glib-1.0-0  1.6.6-1
ii  libusb-1.0-0-dev    2:1.0.26-1

libgusb-dev recommends no packages.

libgusb-dev suggests no packages.

-- no debconf information

>From e5c5697632a33b004cba3c687357f7408a591904 Mon Sep 17 00:00:00 2001
From: Simon McVittie <smcv@debian.org>
Date: Wed, 1 Mar 2023 10:25:00 +0000
Subject: [PATCH 1/2] Add a superficial autopkgtest for libgusb-dev

This checks whether the -dev package has all the required dependencies
to link a simple program with libgusb.

Signed-off-by: Simon McVittie <smcv@debian.org>
---
 debian/tests/control     |  5 +++++
 debian/tests/libgusb-dev | 46 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 51 insertions(+)
 create mode 100644 debian/tests/control
 create mode 100755 debian/tests/libgusb-dev

diff --git a/debian/tests/control b/debian/tests/control
new file mode 100644
index 0000000..2a91858
--- /dev/null
+++ b/debian/tests/control
@@ -0,0 +1,5 @@
+Tests: libgusb-dev
+Restrictions: allow-stderr, superficial
+Depends:
+ build-essential,
+ libgusb-dev,
diff --git a/debian/tests/libgusb-dev b/debian/tests/libgusb-dev
new file mode 100755
index 0000000..22bec3f
--- /dev/null
+++ b/debian/tests/libgusb-dev
@@ -0,0 +1,46 @@
+#!/bin/sh
+# Copyright 2023 Simon McVittie
+# SPDX-License-Identifier: LGPL-2.1-or-later
+
+set -eux
+
+if [ -n "${AUTOPKGTEST_ARTIFACTS-}" ]; then
+    WORKDIR="$AUTOPKGTEST_ARTIFACTS"
+else
+    WORKDIR="$(mktemp -d)"
+    trap 'cd /; rm -fr "$WORKDIR"' 0 INT QUIT ABRT PIPE TERM
+fi
+
+if [ -n "${DEB_HOST_GNU_TYPE:-}" ]; then
+    CROSS_COMPILE="$DEB_HOST_GNU_TYPE-"
+else
+    CROSS_COMPILE=
+fi
+
+cat >> "$WORKDIR"/trivial.c <<EOF
+#include <gusb.h>
+
+#include <glib.h>
+#include <glib-object.h>
+
+int main (int argc, char *argv[])
+{
+  GError *error = NULL;
+  GUsbContext *context = NULL;
+
+  context = g_usb_context_new (&error);
+
+  if (context == NULL)
+    g_error ("%s", error->message);
+
+  g_object_unref (context);
+  return 0;
+}
+EOF
+
+cd "$WORKDIR"
+
+# Deliberately word-splitting pkg-config's output:
+# shellcheck disable=SC2046
+"${CROSS_COMPILE}gcc" -otrivial trivial.c $("${CROSS_COMPILE}pkg-config" --cflags --libs gusb gobject-2.0 glib-2.0)
+./trivial
-- 
2.39.2

--- End Message ---
--- Begin Message --- 
Source: libgusb
Source-Version: 0.4.5-1.1
Done: Jeremy Bicha <jbicha@ubuntu.com>

We believe that the bug you reported is fixed in the latest version of
libgusb, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1032183@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jeremy Bicha <jbicha@ubuntu.com> (supplier of updated libgusb package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 12 Apr 2023 10:16:00 -0400
Source: libgusb
Built-For-Profiles: noudeb
Architecture: source
Version: 0.4.5-1.1
Distribution: unstable
Urgency: medium
Maintainer: Debian UEFI Maintainers <debian-efi@lists.debian.org>
Changed-By: Jeremy Bicha <jbicha@ubuntu.com>
Closes: 1032183
Changes:
 libgusb (0.4.5-1.1) unstable; urgency=medium
 .
   * Non-maintainer upload
 .
   [ Simon McVittie ]
   * Add a superficial autopkgtest for libgusb-dev
   * d/control: Add missing dependency libgusb-dev -> libjson-glib-dev
     (Closes: #1032183)
 .
   [ Laurent Bigonville ]
   * Add missing debian/changelog entry
Checksums-Sha1:
 b2c13ba89ba14964dc5a2d1c8bfa6bb5e66892ec 2385 libgusb_0.4.5-1.1.dsc
 b5931831fbb93fda1cf5e12277a2a9dd224e594d 6908 libgusb_0.4.5-1.1.debian.tar.xz
 6930048177d5abb291ce00be1ec1a6718e198277 8907 libgusb_0.4.5-1.1_source.buildinfo
Checksums-Sha256:
 7050dff005eb8400e197adf46645753938be31a8d07a7b1a68573bfdef58dba9 2385 libgusb_0.4.5-1.1.dsc
 2bcd9f325f10ef7e4226de71596fb8925f0fdcd53a80dd5ed924ee6f9f53ec3a 6908 libgusb_0.4.5-1.1.debian.tar.xz
 5de9d48052a9c9b7552f13aa626830aac0365c6b4f99a4270b4837c814d89d6f 8907 libgusb_0.4.5-1.1_source.buildinfo
Files:
 680b0c0cc5908c0705f6b4ee39c42af3 2385 libs optional libgusb_0.4.5-1.1.dsc
 1a8a0033ec71a9e44bdfda0329ee96e2 6908 libs optional libgusb_0.4.5-1.1.debian.tar.xz
 de3672e87359b4574737fb77c703716b 8907 libs optional libgusb_0.4.5-1.1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEETQvhLw5HdtiqzpaW5mx3Wuv+bH0FAmQ2vb8ACgkQ5mx3Wuv+
bH2RThAAuUFGjNtvjS48xkFwuZ06EWoCcJI6RPatbWjePhP0sCLfz+MZtnQwC+UI
FgJ43840d6j7zDJt8ldFgXrrzpr3Kp9++TwzI3AYABI++95+Pwjn8Fm+hpmS3Rbh
fv47oG0SVqZOgcIaQ5jFhaYwBzAgejO2WsL0qlaGKGd9bxbWizdgscLutcOP/yHq
+BbGUkgo3uyFqv876IEafW6ZiQ2EZlraOCLMrrzWzWaqlUep+bm3+h2DpIS0x7Y1
Y+lbTLrey+rPLCEgy5a1CtZsvFlf/aXuZl2o/FKosu2Qc2biJcMxayzonqWRQRd4
zWyDRnhBZatxEeVuo+JYEvVycV2lxN4V9DSQLUvibSkIxpRd8myp6Pt8ZxuK7jZw
iLCauSiOTPYfRJG8Ph74t4MZCeEFxxuwZPBUfSsCZRy5WXtD1S15VjKUdfXIS4pE
VlwN4w+MYoFlRtbbGJ4IiS3RWhkcJTXK+NJimhVjs49Mr05e+4OBOT+ACKBkQC/Z
XZzSbLhLAE0lq/dylT0kexI1VdNxrPXY0DCigaiGvf1nw0pGx8oKEfsRcJlw5nYw
X0IVxNhcsQEIYOGHQJwUKuSiaDWLvX6QHRrCHBS57Y5ox/7xdPVy9UdWywRJC025
sYq1igiIzSKvfJ88Z+vv14xnQ4vNnG4P4DZrbn2ZPBk/S10P7WM=
=dLLB
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: