On Sat, Jul 16, 2016 at 01:08:51PM +0000, Holger Levsen wrote: > On Sun, Jul 10, 2016 at 12:32:38PM +0200, Wolfgang Schweer wrote: > > To improve it: > > - Check if firefox-esr is really installed before removing iceweasel configuration. > > - Use postinst rather than preinst for most actions. > > - Update firefox-homepage instantly. > > - Handle LTSP chroot case. > > > > Please check and/or test. > > the changes look good to me except for one things: are you sure it's ok > to move this code from preinst to postinst? (mostly double checking, the > code looks good to me) Just in (the rather rare) case both firefox-esr and d-e-c are installed resp. upgraded at the same time it seems better to me to use postinst for most actions. One more change: I believe #779642 (fixed in master) should be dealt with as well in jessie. (Just take cf/cf.krb5,client from master.) --- b/cf.krb5client 2016-07-17 21:12:41.036666393 +0200 +++ a/cf.krb5client 2016-07-17 21:12:23.368792336 +0200 @@ -8,7 +8,7 @@ shellcommands: # setup-roaming generate its own krb5.conf, no need to do it here. - debian.installation.!standalone.!roaming:: + debian.installation.!standalone.!roaming.!server:: "/usr/share/debian-edu-config/tools/sssd-generate-config -k > /etc/krb5.conf" debian.installation.!standalone.secondpass:: Wolfgang
Attachment:
signature.asc
Description: Digital signature