Re: Review cyphesis-cpp
Ok, first round of fixes complete and uploaded. :)
On 10/24/2014 02:32 PM, Tobias Frost wrote:
d/control: The versions of the B-Ds can be dropped -- even oldstable
contains the minimum version.
libavahi-client-dev (>= 0.6.4),
libboost-dev (>=1.40),
libbullet-dev (>= 2.77),
libgcrypt11-dev (>= 1.2),
(I stopped here, please check the rest; check also the binary packages'
dependencies.)
Done and done. I removed any that were older than oldstable.
d/cyphesis-cpp-clients.install -> there is a blank line on top.
d/*.install -> manpages should be installed by dh_installman
Ah, yes, good point! Fixed.
postinst:
The username "cyphesis" could collide with a real-world username. Read
https://wiki.debian.org/AccountHandlingInMaintainerScripts for a
suggestion. The user does not need a shell, I guess, so
use /usr/sbin/nologin as shell.
As you are askink for a password using debconf, please read
http://www.fifi.org/doc/debconf-doc/tutorial.html about passwords.
Thanks for the good references. Fixed according to the suggestions I
found there, along with a little additional Googling.
d/docs:
Don't install NEWS, THANKS and AUTHORS -- they have no information for
the user.
Ok.
Ok, first round completed. I especially did not yet d/copyright review,
but I will do it after I've got feedback from you regarding above.
I got some previous feedback on the d/copyright so it's been completely
rewritten with the assistance of upstream. It *should* be an easy review. ;)
-Olek
Reply to: