Bug#1027050: growing image fails to boot: /scripts/local-bottom/growroot: line 97: wait-for-root: not found

[Martin Pitt <mpitt@debian.org>]

Package: cloud-initramfs-growroot
Version: 0.18.debian11
Severity: important

In our CI we recently tried to refresh our Debian testing image [1], which
exposed a regression: Trying to resize the image with

    qemu-resize <img> 20G

leads to a boot failure:

    Begin: Running /scripts/init-premount ... done.
    Begin: Mounting root file system ... Begin: Running /scripts/local-top ... done.
    Begin: Running /scripts/local-premount ... done.
    Begin: Will now check root file system ... fsck from util-linux 2.38.1
    [/sbin/fsck.ext4 (1) -- /dev/vda1] fsck.ext4 -a -C0 /dev/vda1
    /dev/vda1: clean, 118601/647168 files, 1027851/2588667 blocks
    done.
    [    1.064055] EXT4-fs (vda1): mounted filesystem with ordered data mode. Quota mode: none.
    done.
    Begin: Running /scripts/local-bottom ... [    1.086933] EXT4-fs (vda1): unmounting filesystem.
    GROWROOT: WARNING: resize failed: failed [flock:127] flock -x 9
    /sbin/growpart: line 714: flock: not found
    FAILED: Error while obtaining exclusive lock on /dev/vda
    [    1.114862] GPT:Primary header thinks Alt. header is not at the end of the disk.
    [    1.115544] GPT:20971519 != 41943039
    [    1.115927] GPT:Alternate GPT header not at the end of the disk.
    [    1.116488] GPT:20971519 != 41943039
    [    1.116806] GPT: Use GNU Parted to correct GPT errors.
    [    1.117273]  vda: vda1 vda14 vda15
    /scripts/local-bottom/growroot: line 97: wait-for-root: not found
    done.
    Begin: Running /scripts/init-bottom ... mount: mounting /dev on /root/dev failed: No such file or directory
    mount: mounting /dev on /root/dev failed: No such file or directory
    done.
    mount: mounting /run on /root/run failed: No such file or directory
    BusyBox v1.35.0 (Debian 1:1.35.0-4) multi-call binary.

    Usage: run-init [-d CAP,CAP...] [-n] [-c CONSOLE_DEV] NEW_ROOT NEW_INIT [ARGS]
    [...]

and it lands in the (initramfs) interactive prompt. Pressing Enter then just
quickly fails to boot:

    (initramfs)
    mount: mounting /sys on /root/sys failed: No such file or directory
    mount: mounting /proc on /root/proc failed: No such file or directory
    /init: line 331: can't open /root/dev/console: no such file
    [   10.166875] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000100

The "flock: not found" is #1014662, but that is already present in our current
image with cloud-initramfs-tools 0.18.debian8, and does not seem fatal. So far
the "wait-for-root: not found" seems to be the culprit?

The image build log [2] has a list of all package changes at the bottom. This
includes the kernel (6.0.10-2 -> 6.0.12-1) and two handful of other packages,
but the single one that stands out is

      cloud-initramfs-tools (0.18.debian8 -> 0.18.debian11)

Thanks,

Martin

[1] https://github.com/cockpit-project/bots/pull/4189
[2] https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-logs/debian-testing-20221220-225656.log