On Wednesday, 3 May 2023 03:41:05 CEST James Addison wrote: > I think that the vendor name is coming from a DMI fallback: > > https://sources.debian.org/src/linux/6.1.25-1/drivers/net/wireless/broadcom/ > brcm80211/brcmfmac/common.c/?hl=487#L487 > > Whether the model name is from DMI or from the DTS file's 'model' > field is less clear to me: > > https://sources.debian.org/src/linux/6.1.25-1/arch/arm/boot/dts/bcm2711-rpi-> 400.dts/#L7 AFAIK the most important thing is the "compatible" string. Next to "DMI" there was also mention of "OF", which stand for Open Firmware which is (essentially?) the same as Device Tree > brcmfmac43455-sdio.Raspberry Pi Foundation-Raspberry Pi 4 Model B.txt This looks just plain weird ... and not for the spaces. For the healthiness of the discussion, I chose to ignore that the previous time ;-P I'd double check whether you actually see that line in your own dmesg output, before spending time to find some logic in that name. > Also, to clarify an error/thinko in my previous message: the style of > filename we agreed to map to, and that both linux-firmware.git and the Probably my fault, but I don't think it's relevant "what we agree to". We need to use what the kernel uses of which I suspect there's a (strong) correlation with what's used in the linux-firmware upstream repo. > RPi operating system distro[1] use, is They do their own thing which may or may not have a correlation with what the rest of the world does. > "brcmfmac43456-sdio.raspberrypi,400.txt" (not the short-format > "brcmfmac43455-sdio.txt" that I mentioned). We should include > specificity for vendor and model in the filename, all lowercased, and > without spaces. I realize the spaces are 'annoying' and I fully agree that it shouldn't be tried to get fixed for Bookworm as it more likely breaks then fixes things. But unless you/we manage to convince *upstream* that there is a bug of some sort (and they subsequently change it), what we like/want is not important. We need to follow what upstream does/uses. > The RPi 400 model firmware files are not yet represented in > linux-firmware.git, although they do appear in the RPi operating > system distro. I doubt they ever will be upstreamed ...
Attachment:
signature.asc
Description: This is a digitally signed message part.