[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#983107: os-prober: generic subvolume support for btrfs



Hi Osamu,

Sorry, I think I misunderstood what you meant by "Since we expect any
sane person set-default to the root-filesystem".  I thought you meant
this: since we expect any sane person will run set-default [@] to /

Which really surprised me, because I didn't think anyone had this
position, and I struggled to find reasons to value that perspective
(hence the research!).  Thank you for your patience with that long
reply; it would have been *much* shorter had I not misunderstood.  Now I
think you meant this: since we expect any sane person will set-default
to subvol=/ One good thing that came out of this investigation is
knowing that SUSE uses set-default=@.  Obviously their grub supports
this, because their /boot is the OS partition, and this is btrfs, and it
successfully boots...but I'm not sure if ours does, and if os-prober
will need extra work to support this, or if our grub would benefit from
the hypothetical SUSE patch.

Just now, to be thorough, I checked to see if anything in Debian might
be recommending set-default, or actually executing it, so I did a
codesearch:

https://sources.debian.org/src/systemd/247.3-1/docs/DISCOVERABLE_PARTITIONS.md/?hl=176#L176
 * Recommends using it

https://sources.debian.org/src/btrbk/0.27.1-1.1/doc/FAQ.md/?hl=144#L144
 * Lists it as an equal option to the subvol=@foo method

Luckily we don't have anything unexpected in codesearch that executes
set-default.  

Cheers,
Nicholas

Attachment: signature.asc
Description: PGP signature


Reply to: